Skip to content

fix: cast send --legacy support #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2025
Merged

fix: cast send --legacy support #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c35be96
fix: cast send --legacy support
reecepbcups Mar 18, 2025
a9d2497
changelog
reecepbcups Mar 24, 2025
bdf83fc
Merge branch 'main' into reece/fix-legacy-tx-support-for-foundry
Eric-Warehime Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
### BUG FIXES

- Fixed example chain's cmd by adding NoOpEVMOptions to tmpApp in root.go
- Added RPC support for `--legacy` transactions (Non EIP-1559)

### IMPROVEMENTS

Expand Down
3 changes: 3 additions & 0 deletions rpc/backend/tx_info.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,9 @@ func (b *Backend) GetTransactionReceipt(hash common.Hash) (map[string]interface{
"blockNumber": hexutil.Uint64(res.Height), //nolint:gosec // G115 // won't exceed uint64
"transactionIndex": hexutil.Uint64(res.EthTxIndex), //nolint:gosec // G115 // no int overflow expected here

// https://github.com/foundry-rs/foundry/issues/7640
"effectiveGasPrice": (*hexutil.Big)(txData.GetGasPrice()),

// sender and receiver (contract or EOA) addreses
"from": from,
"to": txData.GetTo(),
Expand Down
Loading