Skip to content

Conversation

@yihuang
Copy link
Contributor

@yihuang yihuang commented Jun 24, 2025

Closes: #220

Description

  1. refactor MsgEthereumTx to contain the raw eth tx:
message MsgEthereumTx {
  option (amino.name) = "cosmos/evm/MsgEthereumTx";
  option (gogoproto.goproto_getters) = false;
  reserved 1,2,3,4;

  // from is the bytes of ethereum signer address. This address value is checked
  // against the address derived from the signature (V, R, S) using the
  // secp256k1 elliptic curve
  bytes from = 5;
  // raw is the raw ethereum transaction
  bytes raw = 6 [(gogoproto.customtype) = "EthereumTx", (gogoproto.nullable) = false];
}
  1. Remove direct reference to TxData and Delete obsolete type files in x/vm/types/
  2. Add a few missing pieces to complete eip-7702 support.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

@yihuang yihuang marked this pull request as ready for review July 17, 2025 02:00
Closes: cosmos#220

cleanup

fix tests

fix evm test cases

fix e2e

fix new tx

Revert "fix new tx"

This reverts commit e58bb44b55397ea9e61131f5523c25a9c94f53d1.

fix unit tests

temp

fix tx defaults

fix e2e test

fix e2e test

fix e2e test

cleanup

fix e2e

fix e2e test

exclude time which doesn't count in hash

align mock

fix mock compare

fix SendRawTransaction
@yihuang yihuang requested review from a team as code owners July 21, 2025 07:08
@aljo242
Copy link
Contributor

aljo242 commented Jul 21, 2025

@yihuang let's fix the lint (go and proto) issues, but the proto breaking CI fail is fine

Copy link
Contributor

@dudong2 dudong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR!
I've reviewed all of this work, and I think it's very graceful. I have a couple of minor comments, which I'd appreciate you checking out.

@yihuang
Copy link
Contributor Author

yihuang commented Jul 29, 2025

@almk-dev to review once conflicts are resolved

conflicts resolved.

@yihuang
Copy link
Contributor Author

yihuang commented Jul 30, 2025

more conflicts just came 🤦‍♂️

@vladjdk
Copy link
Member

vladjdk commented Aug 11, 2025

@yihuang a few more lints and one more conflict before we can merge this

@aljo242
Copy link
Contributor

aljo242 commented Aug 11, 2025

@almk-dev to prioritize reviewing

Copy link
Contributor

@almk-dev almk-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor comments that should be addressed merging.
@yihuang Also, since this is such a big change, can you document the big groups of changes in the PR body? For example:

  • Remove direct references to txData
  • Delete obsolete type files in x/vm/types/
  • Update MsgEthereumTx proto definition to use x, y, z
  • etc.

Copy link
Contributor

@almk-dev almk-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the comments and all the work that went into this!

@almk-dev almk-dev added this pull request to the merge queue Aug 12, 2025
Merged via the queue into cosmos:main with commit 9a1e5bd Aug 12, 2025
18 of 19 checks passed
@yihuang yihuang deleted the evm-msg-optim branch August 12, 2025 15:20
@vladjdk vladjdk mentioned this pull request Aug 13, 2025
zsystm pushed a commit to zsystm/evm that referenced this pull request Nov 2, 2025
* feat: refactor MsgEthereumTx with eth transaction

Closes: cosmos#220

cleanup

fix tests

fix evm test cases

fix e2e

fix new tx

Revert "fix new tx"

This reverts commit e58bb44b55397ea9e61131f5523c25a9c94f53d1.

fix unit tests

temp

fix tx defaults

fix e2e test

fix e2e test

fix e2e test

cleanup

fix e2e

fix e2e test

exclude time which doesn't count in hash

align mock

fix mock compare

fix SendRawTransaction

* fix lint

* feat: update go-ethereum to 1.16

* fix: estimate gas missing fields for new tx type

* support eip-7702

* support eip-7702

* update RPCTransaction

* fix test

* use go-ethereum 1.16

* fix lint

* revert dependency change

* add AuthorizationList EvmTxArgs

* revert dep change

* go mod tidy

* support SetCodeTx in tests

* add debug log for auth failure

* support 7702 in rpc

* fix rpc for modern tx type

* reuse receipt utility in backend

* fix test

* fix test

* fix test

* fix tests

* fix lint

* align tx_args with geth

* fix tests

* fix lint

* fix lint

* rename symbol

* wrap errors

* fix review suggestions

* fix review suggestions

---------

Co-authored-by: Alex | Interchain Labs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Simplify MsgEthereumTx

6 participants