-
Notifications
You must be signed in to change notification settings - Fork 137
feat: refactor MsgEthereumTx with eth transaction #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Closes: cosmos#220 cleanup fix tests fix evm test cases fix e2e fix new tx Revert "fix new tx" This reverts commit e58bb44b55397ea9e61131f5523c25a9c94f53d1. fix unit tests temp fix tx defaults fix e2e test fix e2e test fix e2e test cleanup fix e2e fix e2e test exclude time which doesn't count in hash align mock fix mock compare fix SendRawTransaction
|
@yihuang let's fix the lint (go and proto) issues, but the proto breaking CI fail is fine |
dudong2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR!
I've reviewed all of this work, and I think it's very graceful. I have a couple of minor comments, which I'd appreciate you checking out.
conflicts resolved. |
|
more conflicts just came 🤦♂️ |
|
@yihuang a few more lints and one more conflict before we can merge this |
|
@almk-dev to prioritize reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just minor comments that should be addressed merging.
@yihuang Also, since this is such a big change, can you document the big groups of changes in the PR body? For example:
- Remove direct references to
txData - Delete obsolete type files in
x/vm/types/ - Update
MsgEthereumTxproto definition to use x, y, z - etc.
almk-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all the comments and all the work that went into this!
* feat: refactor MsgEthereumTx with eth transaction Closes: cosmos#220 cleanup fix tests fix evm test cases fix e2e fix new tx Revert "fix new tx" This reverts commit e58bb44b55397ea9e61131f5523c25a9c94f53d1. fix unit tests temp fix tx defaults fix e2e test fix e2e test fix e2e test cleanup fix e2e fix e2e test exclude time which doesn't count in hash align mock fix mock compare fix SendRawTransaction * fix lint * feat: update go-ethereum to 1.16 * fix: estimate gas missing fields for new tx type * support eip-7702 * support eip-7702 * update RPCTransaction * fix test * use go-ethereum 1.16 * fix lint * revert dependency change * add AuthorizationList EvmTxArgs * revert dep change * go mod tidy * support SetCodeTx in tests * add debug log for auth failure * support 7702 in rpc * fix rpc for modern tx type * reuse receipt utility in backend * fix test * fix test * fix test * fix tests * fix lint * align tx_args with geth * fix tests * fix lint * fix lint * rename symbol * wrap errors * fix review suggestions * fix review suggestions --------- Co-authored-by: Alex | Interchain Labs <[email protected]>
Closes: #220
Description
MsgEthereumTxto contain the raw eth tx:TxDataand Delete obsolete type files inx/vm/types/Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranchReviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleasedsection inCHANGELOG.md