Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 016: Validator Consensus Key Rotation #9016

Closed

Conversation

defihyung
Copy link

@defihyung defihyung commented Mar 29, 2021

Description

This PR introduces ADR 016: Validator Consensus Key Rotation, which is the feature for the sake of safer validator key management.

closes: #5233

Related Issues: tendermint/tendermint#1136, #5231


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@robert-zaremba
Copy link
Collaborator

AD-16 is missing a status. Is it accepted? According to architecture/README - it's Proposed. So, I suggest firstly to finalize the ADR before doing the review. That being said it's good to have PoC.

cc: @aaronc

@alexanderbez
Copy link
Contributor

I believe it should be accepted, but it can't hurt to be reviewed by newer stewards of the SDK.

#5233

@clevinson clevinson added the T: ADR An issue or PR relating to an architectural decision record label May 7, 2021
@tac0turtle
Copy link
Member

closing this due to staleness. Feel free to reopen when work resumes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: ADR An issue or PR relating to an architectural decision record
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants