Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: merge grpc entries #9008

Closed
wants to merge 1 commit into from
Closed

Conversation

robert-zaremba
Copy link
Collaborator

Description

In go.mod, why do we have

    google.golang.org/grpc v1.36.0

and then:

replace google.golang.org/grpc => google.golang.org/grpc v1.33.2

It would make more sense to use v1.33.2 in the first place.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@robert-zaremba
Copy link
Collaborator Author

It seams we can't do it: go automatically changed it to v.1.35 because of some other dependencies:

-       google.golang.org/grpc v1.33.2
+       google.golang.org/grpc v1.35.0

IIRC, v1.35 doesn't work for us.

@alessio
Copy link
Contributor

alessio commented Mar 27, 2021

It seams we can't do it: go automatically changed it to v.1.35 because of some other dependencies:

-       google.golang.org/grpc v1.33.2
+       google.golang.org/grpc v1.35.0

IIRC, v1.35 doesn't work for us.

Oww... Do you have any clue about why it doesn't work?

@alessio alessio deleted the robert/gomod-grpc branch March 27, 2021 03:47
@robert-zaremba
Copy link
Collaborator Author

Oww... Do you have any clue about why it doesn't work?

I don't remember. It fails in tests I think. @AmauryM - do you remember what was wrong there?

@amaury1093
Copy link
Contributor

amaury1093 commented Mar 30, 2021

See #8392 and #8162: gogoproto and grpc don't play well together. The decision in 8392 was wontfix and to wait the update to proto api v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants