Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SendToModuleAccountTest #8857

Merged
merged 3 commits into from
Mar 11, 2021
Merged

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Mar 11, 2021

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jgimeno jgimeno changed the title Fix SentToModuleAccountTest Fix SendToModuleAccountTest Mar 11, 2021
@jgimeno jgimeno marked this pull request as ready for review March 11, 2021 13:03
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #8857 (9f60613) into master (8f7cdaf) will decrease coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8857      +/-   ##
==========================================
- Coverage   59.44%   59.43%   -0.01%     
==========================================
  Files         563      563              
  Lines       31286    31284       -2     
==========================================
- Hits        18598    18595       -3     
- Misses      10522    10523       +1     
  Partials     2166     2166              
Impacted Files Coverage Δ
crypto/keyring/keyring.go 59.29% <0.00%> (-0.18%) ⬇️
simapp/app.go 83.24% <100.00%> (-0.26%) ⬇️

@alessio alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 11, 2021
@alessio alessio merged commit 280ee4f into master Mar 11, 2021
@alessio alessio deleted the jonathan/fix-module-account-failing-test branch March 11, 2021 14:20
mergify bot pushed a commit that referenced this pull request Mar 11, 2021
(cherry picked from commit 280ee4f)

# Conflicts:
#	x/bank/app_test.go
alessio pushed a commit that referenced this pull request Mar 11, 2021
* Fix SendToModuleAccountTest (#8857)

(cherry picked from commit 280ee4f)

Co-authored-by: Jonathan Gimeno <[email protected]>
Co-authored-by: Alessio Treglia <[email protected]>
jinsan-line added a commit to Finschia/finschia-sdk that referenced this pull request Mar 17, 2021
* Fix SendToModuleAccountTest
* cosmos/cosmos-sdk#8857
* cosmos/cosmos-sdk@280ee4f

Co-authored-by: Jonathan Gimeno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants