Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename InfoImporter -> LegacyInfoImporter #8739

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 1, 2021

Avoid namespace clash with the InfoImporter interface
that already exists in the v0.41 release series.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Avoid namespace clash with the InfoImporter interface
that already exists in the v0.41 release series.
@alessio alessio added A:automerge Automatically merge PR once all prerequisites pass. and removed A:automerge Automatically merge PR once all prerequisites pass. labels Mar 1, 2021
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #8739 (a73c877) into master (1c6e267) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8739   +/-   ##
=======================================
  Coverage   61.44%   61.44%           
=======================================
  Files         673      673           
  Lines       38361    38361           
=======================================
  Hits        23571    23571           
  Misses      12309    12309           
  Partials     2481     2481           
Impacted Files Coverage Δ
crypto/keyring/keyring.go 59.46% <ø> (ø)
client/keys/migrate.go 56.33% <100.00%> (ø)

Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but could you explain the motivation? There is no other InfoImporter. As you wrote in the description there was one in the past, but it's not clear what's the problem with keeping the same name?

@alessio
Copy link
Contributor Author

alessio commented Mar 1, 2021

@robert-zaremba there is one InfoImporter interface in the keyring package of 0.41. The interfaces' methods are different

@alessio alessio merged commit 010eeef into master Mar 1, 2021
@alessio alessio deleted the alessio/fix-infoimporter-name-clash branch March 1, 2021 20:09
mergify bot pushed a commit that referenced this pull request Mar 1, 2021
Avoid namespace clash with the InfoImporter interface
that already exists in the v0.41 release series.

(cherry picked from commit 010eeef)

# Conflicts:
#	client/keys/migrate.go
#	crypto/keyring/keyring.go
@robert-zaremba
Copy link
Collaborator

@robert-zaremba there is one InfoImporter interface in the keyring package of 0.41. The interfaces' methods are different

Ah, I was looking at master :palm_face:

alessio pushed a commit that referenced this pull request Mar 2, 2021
Avoid namespace clash with the InfoImporter interface
that already exists in the v0.41 release series.
alessio pushed a commit that referenced this pull request Mar 2, 2021
* crypto/keyring: fix offline keys migration (#8639)

Fix `keys migrate` command (#8703)

crypto/keyring: reinstate the InfoImporter interface

InfoImporter is implemented by those Keyring implementations
that support import of Info objects.

Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Jonathan Gimeno <[email protected]>
Co-authored-by: Amaury <[email protected]>

* refresh golangci-lint

* Rename InfoImporter -> LegacyInfoImporter (#8739)

Avoid namespace clash with the InfoImporter interface
that already exists in the v0.41 release series.

* Revert "refresh golangci-lint"

This reverts commit 38e1349.

Co-authored-by: SaReN <[email protected]>
Co-authored-by: Jonathan Gimeno <[email protected]>
Co-authored-by: Amaury <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants