-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuzz: add types.ParseCoin #8513
Conversation
cc @odeke-em |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a basic README would be useful.
I can see the corpus/*.seed
files being used, but have no idea why the other files are committed. Also, would like to know who to run the fuzzer.
Great stuff. Can we move the fuzzy test data into I agree with @amaurymartiny too as I'd love to integrate the fuzzer in our buildsystem. |
Go fuzz can be part of go1.17 https://go.googlesource.com/proposal/+/master/design/draft-fuzzing.md In the meantime, I don't know what's the best way to do this, other than following go-fuzz readme. Any idea @odeke-em ? |
can you add a quick README file here. I realize we can go to go-fuzz to see how to run these but lets get some docs in here to avoid the extra step. It can also be a copy with minor adjustments of what is in the go-fuzz repo. |
@cuonglm could you please add a short readme on how to run these tests? |
Sure, to be clear, you mean add readme for how to run this with go-fuzz? |
Yes, how to run them, what dependencies are required. This avoids the dev from going elsewhere to read docs. |
Updates #7921
after linting is fixed we can merge this |
It seems weird, since when the golangci-lint error seems not related to this change. Maybe we can just merge this and fix in the |
Description
Add fuzzing for types.ParseCoin.
Updates #7921
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes