Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for feegrant #8496

Merged
merged 11 commits into from
Feb 4, 2021
Merged

Add specs for feegrant #8496

merged 11 commits into from
Feb 4, 2021

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Feb 3, 2021

Description

closes: #8456

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@atheeshp atheeshp changed the title Atheesh/feegrant specs Adds specs for feegrant Feb 3, 2021
@atheeshp atheeshp changed the title Adds specs for feegrant Add specs for feegrant Feb 3, 2021
@atheeshp atheeshp marked this pull request as ready for review February 3, 2021 10:03
blushi
blushi suggested changes Feb 3, 2021
View reviewed changes
x/feegrant/spec/01_concepts.md Outdated Show resolved Hide resolved
x/feegrant/spec/01_concepts.md Outdated Show resolved Hide resolved
x/feegrant/spec/01_concepts.md Outdated Show resolved Hide resolved
x/feegrant/spec/01_concepts.md Outdated Show resolved Hide resolved
x/feegrant/spec/01_concepts.md Outdated Show resolved Hide resolved
x/feegrant/spec/01_concepts.md Outdated Show resolved Hide resolved
x/feegrant/spec/01_concepts.md Outdated Show resolved Hide resolved
x/feegrant/spec/01_concepts.md Outdated Show resolved Hide resolved
x/feegrant/spec/README.md Outdated Show resolved Hide resolved
x/feegrant/spec/README.md Outdated Show resolved Hide resolved
@atheeshp atheeshp requested a review from blushi February 3, 2021 12:17
@amaury1093 amaury1093 added T:Docs Changes and features related to documentation. C:x/feegrant labels Feb 4, 2021
amaury1093
amaury1093 reviewed Feb 4, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, mostly grammar nits.

x/feegrant/spec/01_concepts.md Outdated Show resolved Hide resolved
x/feegrant/spec/01_concepts.md Outdated Show resolved Hide resolved
x/feegrant/spec/01_concepts.md Outdated Show resolved Hide resolved
x/feegrant/spec/01_concepts.md Outdated Show resolved Hide resolved
x/feegrant/spec/01_concepts.md Outdated Show resolved Hide resolved
x/feegrant/spec/03_messages.md Outdated Show resolved Hide resolved
x/feegrant/spec/03_messages.md Outdated Show resolved Hide resolved
x/feegrant/spec/03_messages.md Outdated Show resolved Hide resolved
x/feegrant/spec/README.md Outdated Show resolved Hide resolved
x/feegrant/spec/01_concepts.md Outdated Show resolved Hide resolved
@atheeshp atheeshp requested a review from amaury1093 February 4, 2021 11:55
blushi
blushi approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving

x/feegrant/spec/README.md Outdated Show resolved Hide resolved
x/feegrant/spec/README.md Outdated Show resolved Hide resolved
@atheeshp @blushi
address review changes
54e0794 
Co-authored-by: Marie Gauthier <[email protected]>
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 4, 2021
@mergify mergify bot merged commit 0af248b into master Feb 4, 2021
@mergify mergify bot deleted the atheesh/feegrant-specs branch February 4, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blushi blushi blushi approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@aleem1314 aleem1314 Awaiting requested review from aleem1314

@anilcse anilcse Awaiting requested review from anilcse

@clevinson clevinson Awaiting requested review from clevinson

@robert-zaremba robert-zaremba Awaiting requested review from robert-zaremba

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/feegrant T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write SPEC for x/fee_grant
3 participants
@atheeshp @amaury1093 @blushi