-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update master docs #8353
Merged
Merged
docs: update master docs #8353
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d927d73
bump docs theme to 1.0.180
lovincyrus a189ff6
add v0.40 to config.js versions
lovincyrus 3411b80
Merge branch 'master' into cyrus/master-docs
okwme 26bb55a
resolve conflicts
lovincyrus dc51027
Merge branch 'master' into cyrus/master-docs
lovincyrus f91c549
Fix code snippet link
amaury1093 8537107
Merge branch 'master' into cyrus/master-docs
lovincyrus e98f849
Merge branch 'master' into cyrus/master-docs
okwme b0423d6
Merge branch 'master' into cyrus/master-docs
lovincyrus 9989bea
reorganize order of versions
lovincyrus df9f27e
Merge branch 'master' into cyrus/master-docs
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the v0.40 has been kind of yanked, should we just show v0.39, v0.41 and master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we don't plan on using v0.40, then we shouldn't include it in the version dropdown. Can you confirm that? @amaurymartiny
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about this. A recent bugfix (#8461) makes 0.40.* and 0.41.* buggy for ALL chains except gaia. Maybe in the docs we should just skip 0.40 and 0.41 altogether? And show 0.42 directly?
cc @clevinson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or actually, for 0.41, it would be ideal to show a banner on top of the page saying "if you're not using the hub, please upgrade to 0.42". wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes i like this approach. Let's only show docs for v0.41 and v0.42, and have v0.41 clearly point out that there is an evidence bug on v0.41.x that renders chains unstable on v0.41.x if they have a non-default bech32 prefix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lovincyrus can we update this accordingly & merge? This should also include then an update to the
versions
file, as we now have arelease/v0.41.x
branch, and most stargate docs updates will only be be backported to there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we only showing v0.41 and v0.42 and get rid of v0.39 and master from the version dropdown?nvm, just saw this #8353 (review)