gRPC-web proxy #8077
Merged
gRPC-web proxy #8077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eem/7345-grpc-web-proxy
Codecov Report
@@ Coverage Diff @@
## master #8077 +/- ##
==========================================
- Coverage 61.91% 61.91% -0.01%
==========================================
Files 609 610 +1
Lines 35100 35135 +35
==========================================
+ Hits 21732 21753 +21
- Misses 11085 11096 +11
- Partials 2283 2286 +3
|
…eem/7345-grpc-web-proxy
…eem/7345-grpc-web-proxy
…eem/7345-grpc-web-proxy
aleem1314
requested review from
aaronc,
alessio and
alexanderbez
as code owners
amaury1093
reviewed
Dec 15, 2020
server/config/toml.go
Outdated
Comment on lines
154
to
158
| # BindAddress defines address to bind the server to. | ||
| bind-address = "{{ .GRPC.GRPCWebProxy.BindAddress }}" | ||
|
|
||
| # HTTPPort defines TCP port to listen on for HTTP1.1 debug calls. | ||
| http-port = {{ .GRPC.GRPCWebProxy.HTTPPort }} |
There was a problem hiding this comment.
is it possible to bind to the same port as the grpc-gateway rest server?
alexanderbez
suggested changes
Dec 15, 2020
fedekunze
added
the
C: gRPC
Co-authored-by: Anil Kumar Kammari <[email protected]>
amaury1093
reviewed
Jan 4, 2021
Comment on lines
+118
to
+119
| // Address defines the gRPC-web server to listen on | ||
| Address string `mapstructure:"address"` |
There was a problem hiding this comment.
We could also just keep the enable config, and if true, bind the server to the HTTP port. I'm not sure it's useful to expose so many ports. wdyt?
There was a problem hiding this comment.
I tried to bind to the HTTP server. Getting this error.
There was a problem hiding this comment.
I created this issue to discuss it: #8254
Co-authored-by: Amaury <[email protected]>
Co-authored-by: Amaury <[email protected]>
4 tasks
|
@alexanderbez Since you requested changes in a previous iteration, could you have another look at this PR? |
alexanderbez
suggested changes
Jan 11, 2021
alexanderbez
approved these changes
Jan 14, 2021
amaury1093
added
the
A:automerge
sunnya97
pushed a commit
to sikkatech/cosmos-sdk
that referenced
this pull request
Jan 19, 2021
* init * WIP config * WIP add proxy server * fmt * WIP * setup proxy server * clean go.mod * lint * lint * lint * custom codec * lint * add comments * change grpc-proxy port * add grpc-web * update server/start.go * add tests * add test with client * Update server/start.go Co-authored-by: Anil Kumar Kammari <[email protected]> * Update server/start.go Co-authored-by: Amaury <[email protected]> * Update server/start.go Co-authored-by: Amaury <[email protected]> * review changes * review changes * Update server/start.go Co-authored-by: Anil Kumar Kammari <[email protected]> Co-authored-by: Amaury <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #7345
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes