Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version --long displays replaced build dependencies #7941

Merged
merged 9 commits into from
Nov 16, 2020

Conversation

hanjukim
Copy link
Contributor

@hanjukim hanjukim commented Nov 16, 2020

Description

The version command now displays replaced modules in build dependencies

closes: #7940


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@hanjukim hanjukim changed the title version --long displays replaced modules version --long displays replaced build dependencies Nov 16, 2020
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #7941 (74a667c) into master (cd29fd6) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7941      +/-   ##
==========================================
- Coverage   54.17%   54.17%   -0.01%     
==========================================
  Files         612      612              
  Lines       38994    38996       +2     
==========================================
  Hits        21125    21125              
- Misses      15697    15699       +2     
  Partials     2172     2172              

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@alessio alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 16, 2020
@mergify mergify bot merged commit b5e873c into cosmos:master Nov 16, 2020
alessio pushed a commit that referenced this pull request Nov 16, 2020
@hanjukim hanjukim deleted the version-replace-module branch November 17, 2020 08:30
clevinson pushed a commit that referenced this pull request Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version --long does not reflect replace directive
3 participants