Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IAVL]: Bump to v0.15.0-rc4 #7549

Merged
merged 6 commits into from
Oct 19, 2020
Merged

[IAVL]: Bump to v0.15.0-rc4 #7549

merged 6 commits into from
Oct 19, 2020

Conversation

clevinson
Copy link
Contributor

@clevinson clevinson commented Oct 14, 2020 •
edited
Loading

Description

Bumps to IAVL v0.15.0-rc4

Full changelog in this latest RC here.

Only breaking change:

  • iavl#317 LoadVersion() and LazyLoadVersion() now error if called with a positive version number on an empty tree.

I don't have 100% visibility into our full usage of store.LoadStore() and store.LoadStoreWithInitialVersion(), but these functions both now will return with error if called with positive version on an empty IAVL tree.

I assume that this was already expected behavior, and now IAVL is properly handling that case. LMK if there is any additional work necessary, or if we should be handling that error case differently.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Oct 14, 2020 •
edited
Loading

Codecov Report

Merging #7549 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7549   +/-   ##
=======================================
  Coverage   54.19%   54.19%           
=======================================
  Files         610      610           
  Lines       38363    38363           
=======================================
  Hits        20791    20791           
  Misses      15465    15465           
  Partials     2107     2107

@erikgrinaker
Copy link
Contributor

Yes, the old behavior was faulty, so the breaking change is considered a bugfix. However, the changes in #7415 could possibly be affected by this.

@clevinson
Copy link
Contributor Author

clevinson commented Oct 14, 2020 •
edited
Loading

@erikgrinaker thanks for flagging. I hadn't caught that. Tests are passing... so i'm not sure exactly what needs upgrading. i'd love input from @alexanderbez or @RiccardoM on what updates are necessary to #7415, and what the expected behavior is so i can write a corresponding test case.

fedekunze
fedekunze suggested changes Oct 15, 2020
View reviewed changes
go.mod Show resolved Hide resolved
@taariq
Copy link

taariq commented Oct 15, 2020

@alexanderbez you have any time to put some eyes on this?

amaury1093
amaury1093 approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@clevinson clevinson added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 16, 2020
@clevinson clevinson mentioned this pull request Oct 19, 2020
Merged
31 tasks
@mergify mergify bot merged commit 505d424 into master Oct 19, 2020
@mergify mergify bot deleted the clevinson/iavl-0.15-rc4 branch October 19, 2020 18:38
clevinson added a commit that referenced this pull request Oct 19, 2020
@clevinson @mergify
[IAVL]: Bump to v0.15.0-rc4 (#7549)
77dd62b 
* iavl 0.15.0-rc4 version bump

* update comments on error modes for store.LoadStore

* update CONFIO_URL in makefile

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
clevinson added a commit that referenced this pull request Oct 19, 2020
@clevinson @blushi
@mergify @amaury1093 @fedekunze @colin-axner @njmurarka @RiccardoM @tac0turtle @alexanderbez @dependabot @zmanian @cwgoes @aaronc
[backports] v0.40.0-rc1 (#7590)
d2a6cce 
* Update Encoding Doc for 0.40 (#7430)

* Remove deprecated docs and add first guidelines to protobuf migration

* Add conventions

* Reorder and add more FAQ doc

* Update guidelines for pb msg definitions

* Use commit hash in github links

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* docs: Update "Basics" section (#7416)

* Prettier

* docs: Update "Basics" section

* appcli -> appd

* Better wording

* Fix to appCodec

* Add gRPC mention

* Add grpc

* Reference simapp code

* Update docs/basics/accounts.md

Co-authored-by: Marie Gauthier <[email protected]>

* Add section about gRPC query services

* Optional LegacyQuerierHandler

* Clearer docs

* Update docs/basics/app-anatomy.md

Co-authored-by: Marie Gauthier <[email protected]>

* Update docs/basics/app-anatomy.md

Co-authored-by: Federico Kunze <[email protected]>

* Address comments

* Address comments

* Update docs/basics/accounts.md

Co-authored-by: Marie Gauthier <[email protected]>
Co-authored-by: Federico Kunze <[email protected]>

* Fix misbehaviour handling for solo machine (#7515)

* add timestamp to SignatureAndData

Add timestamp field to signature and data. Add ValidateBasic check for timestamp. Add ValidateBasic test. Update misbehaviour handler to use supplied timestamp.

* fix typo

* add timestamp check

* fix lint

Co-authored-by: Federico Kunze <[email protected]>

* update solo machine specs (#7512)

* update solo machine specs

* update concepts

* self review fixes

* Apply suggestions from code review

* add note on upgarding solo machines

Co-authored-by: Federico Kunze <[email protected]>

* Corrected 'unsafe-reset-all' help text (#7504)

* Merge PR #7415: Return empty store tree on non-existing version

* tendermint: update sdk to rc5 (#7527)

* update sdk to rc5

* Update baseapp/params.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Bump github.com/spf13/cobra from 1.0.0 to 1.1.0 (#7553)

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.0.0 to 1.1.0.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md)
- [Commits](spf13/cobra@v1.0.0...v1.1.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* remove test_utils.go in tm client (#7522)

* remove test_utils from tm client

* fix build

* fix lint?

* fix lint?

* apply @fedekunze review suggestion

* add tests as per @alessio suggestion

* fix typo

* ibc: cleanup channel types test (#7521)

* Update Building Modules documentation (#7473)

* Update module-manager.md

* Update modules #messages doc

* Fix typo

* Update message implementation example link

* Update messages-and-queries.md#queries doc

* Update querier.md

* Update handler.md

* Update links in beginblock-endblock.md

* Update keeper.md

* Update invariants.md

* Update genesis.md

* Update module-interfaces.md#transaction-commands

* Update module-interfaces.md#query-commands

* Update module-interfaces.md#flags

* Update module-interfaces.md#rest

* Update structure.md

* Update module-interfaces.md#grpc

* Update errors.md

* Update module-interfaces.md#grpc-gateway-rest

* Add more info on swagger

* Address comments

* Fix go.sum

* Fix app-anatomy.md

* Update docs/building-modules/module-interfaces.md

Co-authored-by: Federico Kunze <[email protected]>

* Update docs/building-modules/querier.md

Co-authored-by: Federico Kunze <[email protected]>

* Update docs/building-modules/querier.md

Co-authored-by: Federico Kunze <[email protected]>

* Update docs/building-modules/module-interfaces.md

Co-authored-by: Federico Kunze <[email protected]>

* Update docs/building-modules/module-interfaces.md

Co-authored-by: Federico Kunze <[email protected]>

* Address part of review comments

* Update old ref of RegisterQueryService

* Add example code for Manager

* Update queriers.md to query-services.md and refs

* Add new query-services.md

* Revert "Update old ref of RegisterQueryService"

This reverts commit 1ea1ea8.

* Update keeper.md

* Update handler.md

* Update handler.md

* Update messages-and-queries.md

* Update docs/basics/app-anatomy.md

Co-authored-by: Amaury Martiny <[email protected]>

* Update docs/building-modules/intro.md

Co-authored-by: Amaury Martiny <[email protected]>

* Fix typo

Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: Amaury Martiny <[email protected]>

* client: add GetAccount and GetAccountWithHeight to AccountRetriever (#7558)

* client: add GetAccount and GetAccountWithHeight to AccountRetriever

* update ADR

* address comments from review

* Add the option of emitting amino encoded json from the CLI (#7221)

* Add the option of emitting amino encoded json

* Update AMINO JSON serialization with ConvertTxToStdTx

* Make the Amino flag more self documenting by serializing the BroadcastRequest type instead of StdTx

* Handle amino encoding error

* Update x/auth/client/cli/tx_multisign.go

Co-authored-by: Alessio Treglia <[email protected]>

* Update x/auth/client/cli/tx_sign.go

Co-authored-by: Alessio Treglia <[email protected]>

* Apply suggestions from code review

Co-authored-by: Alessio Treglia <[email protected]>

* Fix go format

Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* ibc: update solo machine client command (#7579)

Co-authored-by: Federico Kunze <[email protected]>

* docs: Revert SPEC-SPEC and update x/{auth,bank,evidence,slashing} (#7407)

* Revert some changes from #7404

* Update x/slashing

* Address review comments

* Small tweak

Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* remove id in localhost (#7577)

Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: Christopher Goes <[email protected]>

* update changelog

* Update CHANGELOG.md

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Fix solomachine cmds (#7581)

* fix solo machine cli cmds

* polish

Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* simapp: use tmjson on InitChainer (#7514)

Co-authored-by: Alessio Treglia <[email protected]>

* [IAVL]: Bump to v0.15.0-rc4 (#7549)

* iavl 0.15.0-rc4 version bump

* update comments on error modes for store.LoadStore

* update CONFIO_URL in makefile

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Handle nil *Any in UnpackAny and add panic handler for tx decoding (#7594)

* Handle nil any in UnpackAny

* Add test

* Add flag back

* Update runTx signature

* Update Simulate signature

* Update calls to Simulate

* Add txEncoder in baseapp

* Fix TestTxWithoutPublicKey

* Wrap errors

* Use amino in baseapp tests

* Add txEncoder arg to Check & Deliver

* Fix gas in test

* Fix remaining base app tests

* Rename to amionTxEncoder

* Update codec/types/interface_registry.go

Co-authored-by: Aaron Craelius <[email protected]>

* golangci-lint fix

Co-authored-by: Amaury Martiny <[email protected]>
Co-authored-by: Aaron Craelius <[email protected]>
Co-authored-by: Cory Levinson <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: Marie Gauthier <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Amaury Martiny <[email protected]>
Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Neeraj Murarka <[email protected]>
Co-authored-by: Riccardo Montagnin <[email protected]>
Co-authored-by: Marko <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Zaki Manian <[email protected]>
Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Christopher Goes <[email protected]>
Co-authored-by: Aaron Craelius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@fedekunze fedekunze fedekunze approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@erikgrinaker erikgrinaker Awaiting requested review from erikgrinaker

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@clevinson @erikgrinaker @taariq @amaury1093 @alexanderbez @fedekunze