Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: move ledger code to its own subfolder #6817

Merged
merged 2 commits into from
Jul 22, 2020
Merged

crypto: move ledger code to its own subfolder #6817

merged 2 commits into from
Jul 22, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jul 22, 2020 •
edited
Loading

crypto -> crypto/ledger:

  • crypto.LedgerShowAddress -> ledger.ShowAddress
  • crypto.NewPrivKeyLedgerSecp256k1 - > ledger.NewPrivKeySecp256k1
  • crypto.NewPrivKeyLedgerSecp256k1Unsafe -> ledger.NewPrivKeySecp256k1Unsafe

Closes: #6780

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 22, 2020 •
edited
Loading

Codecov Report

Merging #6817 into master will not change coverage.
The diff coverage is 93.75%.

@@           Coverage Diff           @@
##           master    #6817   +/-   ##
=======================================
  Coverage   61.27%   61.27%           
=======================================
  Files         510      510           
  Lines       31555    31555           
=======================================
  Hits        19334    19334           
  Misses      10720    10720           
  Partials     1501     1501

crypto: move ledger code to its own subfolder
befd78d 
crypto -> crypto/ledger:
- crypto.LedgerShowAddress -> ledger.ShowAddress
- crypto.NewPrivKeyLedgerSecp256k1 - > ledger.NewPrivKeySecp256k1
- crypto.NewPrivKeyLedgerSecp256k1Unsafe -> ledger.NewPrivKeySecp256k1Unsafe

Closes: #6780
@alessio alessio force-pushed the alessio/6780-create-ledger-package branch from c2ad91b to befd78d Compare July 22, 2020 15:20
@alessio alessio changed the title Alessio/6780 create ledger package crypto: move ledger code to its own subfolder Jul 22, 2020
@alessio alessio marked this pull request as ready for review July 22, 2020 15:21
fedekunze
fedekunze approved these changes Jul 22, 2020
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedekunze fedekunze added T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). C:Crypto C:Ledger Issues and features related Ledger integration and functionality labels Jul 22, 2020
@alessio alessio merged commit e0a81d2 into master Jul 22, 2020
@alessio alessio deleted the alessio/6780-create-ledger-package branch July 22, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@clevinson clevinson Awaiting requested review from clevinson

@jgimeno jgimeno Awaiting requested review from jgimeno

Assignees
No one assigned
Labels
C:Crypto C:Ledger Issues and features related Ledger integration and functionality T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: Move ledger code to its own subfolder
2 participants
@alessio @fedekunze