CLI/Tests: Remove Fixtures #6799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6799 +/- ##
==========================================
+ Coverage 55.60% 55.79% +0.19%
==========================================
Files 457 224 -233
Lines 27440 14128 -13312
==========================================
- Hits 15257 7883 -7374
+ Misses 11083 5670 -5413
+ Partials 1100 575 -525 |
alexanderbez
requested review from
aaronc,
alessio,
clevinson,
fedekunze and
jgimeno
as code owners
alexanderbez
added
A:automerge
amaury1093
reviewed
Jul 21, 2020
tac0turtle
approved these changes
Jul 21, 2020
amaury1093
suggested changes
Jul 21, 2020
alessio
reviewed
Jul 21, 2020
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/env bash | |||
| set -e | |||
|
|
|||
| PKGS=$(go list ./... | grep -v '/simapp' | grep -v '/cli_test') | |||
| PKGS=$(go list ./... | grep -v '/simapp') | |||
There was a problem hiding this comment.
I'm not sure this script is used at all. It is mentioned in a Makefile's target but it does not seem to be used anymore.
There was a problem hiding this comment.
It's used by test-cover, but that isn't used by anything. Let's remove it in a subsequent PR.
Co-authored-by: Amaury Martiny <[email protected]>
amaury1093
approved these changes
Jul 21, 2020
chengwenxi
pushed a commit
to irisnet/cosmos-sdk
that referenced
this pull request
Jul 22, 2020
* remove fixtures * setup tests * update x/mint * cli: update x/staking commands * tests: convert x/staking CLI tests * tests: fix x/auth CLI tests * cli updates * fix buiild * fix build * Update x/gov/client/cli/cli_test.go Co-authored-by: Amaury Martiny <[email protected]> * remove GenerateOrBroadcastTx * move TestCLIQueryConn Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Amaury Martiny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
x/mintCLI tests to in-processx/stakingCLI tests to in-processx/govCLI tests to in-processref: #6571
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes