x/staking: cli migration to use gRPC query client #6728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atheeshp
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6728 +/- ##
==========================================
+ Coverage 59.94% 62.74% +2.80%
==========================================
Files 513 386 -127
Lines 31434 23889 -7545
==========================================
- Hits 18842 14989 -3853
+ Misses 11156 7810 -3346
+ Partials 1436 1090 -346 |
amaury1093
reviewed
Jul 15, 2020
This was referenced Jul 15, 2020
…21-grpc-cli-migration-staking
atheeshp
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
blushi
reviewed
Jul 16, 2020
There was a problem hiding this comment.
LGTM overall.
Just a small comment, shouldn't we remove
cosmos-sdk/x/staking/client/cli/query.go
Lines 173 to 174 in aa6699c
fedekunze
approved these changes
Jul 16, 2020
…21-grpc-cli-migration-staking
…21-grpc-cli-migration-staking
…21-grpc-cli-migration-staking
fedekunze
added
A:automerge
20 tasks
…21-grpc-cli-migration-staking
…cosmos/cosmos-sdk into atheesh/5921-grpc-cli-migration-staking
amaury1093
approved these changes
Jul 17, 2020
fedekunze
reviewed
Jul 17, 2020
| @@ -61,6 +61,9 @@ const ( | |||
| FlagPage = "page" | |||
There was a problem hiding this comment.
should we remove this one?
There was a problem hiding this comment.
May be yes after all module migrations done.
There was a problem hiding this comment.
yeah, agreed with @atheeshp: auth,ibc,evidence,gov etc are all using FlagPage, probably should wait for those modules to switch to using gRPC & query.PageRequest first, or else this PR will become too big.
anilcse
reviewed
Jul 17, 2020
…21-grpc-cli-migration-staking
…cosmos/cosmos-sdk into atheesh/5921-grpc-cli-migration-staking
anilcse
requested changes
Jul 17, 2020
blushi
approved these changes
Jul 17, 2020
anilcse
approved these changes
Jul 17, 2020
9 tasks
chengwenxi
pushed a commit
to irisnet/cosmos-sdk
that referenced
this pull request
Jul 22, 2020
* migrated to use gRPC query client * removed codecs usage * review change * added read command flags * added pagination flags * fixed limit issue * added helper function for default pagination flags * review changes * review change * review changes Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #5921
closes: #6617
Description
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes