Server/simd: Viper Removal #6599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6599 +/- ##
==========================================
- Coverage 57.11% 56.89% -0.22%
==========================================
Files 484 485 +1
Lines 29148 29166 +18
==========================================
- Hits 16647 16594 -53
- Misses 11313 11384 +71
Partials 1188 1188 |
alexanderbez
changed the title
alexanderbez
requested review from
aaronc,
alessio,
clevinson,
fedekunze and
jgimeno
as code owners
9 tasks
alexanderbez
changed the title
alexanderbez
added
the
A:automerge
alessio
approved these changes
Jul 5, 2020
jgimeno
reviewed
Jul 5, 2020
tac0turtle
reviewed
Jul 5, 2020
sahith-narahari
approved these changes
Jul 5, 2020
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* init commit * remove viper from tm cmds * updates * Undo x/bank/client/cli/tx.go * Fix unit tests * lint++ * rename var * Fix genutil test * fix test * prefer cmd.Flags() over direct viper usage * update * fix ABCI error tests * fix integration tests * Add viper to context * fix build * fix unit test * Implement and use AppOptions * Revert Redact godoc Co-authored-by: Alessio Treglia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
serverpkg andsimdCLI pkgviper.Get*outside of command handlerscmd.Flags()directly inside command handlersref: #6571
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes