x/evidence: gRPC query service #6593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blushi
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6593 +/- ##
==========================================
- Coverage 61.34% 57.67% -3.67%
==========================================
Files 380 502 +122
Lines 22868 30040 +7172
==========================================
+ Hits 14029 17327 +3298
- Misses 7845 11463 +3618
- Partials 994 1250 +256 |
This was referenced Jul 3, 2020
fedekunze
suggested changes
Jul 8, 2020
| } | ||
| evidenceAny, err := ConvertEvidence(result) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
ditto unregistered evidence test case
amaury1093
reviewed
Jul 8, 2020
Co-authored-by: Amaury Martiny <[email protected]>
…-sdk into marie/5921-grpc-x-evidence
amaury1093
reviewed
Jul 9, 2020
fedekunze
approved these changes
Jul 10, 2020
fedekunze
added
C:x/evidence
A:automerge
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #5921
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes