Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/upgrade gRPC query service #6590

Merged
merged 11 commits into from
Jul 4, 2020
Merged

x/upgrade gRPC query service #6590

merged 11 commits into from
Jul 4, 2020

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Jul 3, 2020

Description

ref: #5921


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@amaury1093 amaury1093 added the WIP label Jul 3, 2020
@aaronc aaronc mentioned this pull request Jul 3, 2020
43 tasks
@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #6590 into master will increase coverage by 1.50%.
The diff coverage is 66.12%.

@@            Coverage Diff             @@
##           master    #6590      +/-   ##
==========================================
+ Coverage   55.60%   57.10%   +1.50%     
==========================================
  Files         457      484      +27     
  Lines       27440    29145    +1705     
==========================================
+ Hits        15257    16644    +1387     
- Misses      11083    11313     +230     
- Partials     1100     1188      +88     

@amaury1093 amaury1093 added R4R and removed WIP labels Jul 3, 2020
@amaury1093 amaury1093 marked this pull request as ready for review July 3, 2020 20:31
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few documentation comments. Otherwise LGTM. Good work! 🎉

proto/cosmos/upgrade/query.proto Outdated Show resolved Hide resolved
proto/cosmos/upgrade/query.proto Outdated Show resolved Hide resolved
proto/cosmos/upgrade/query.proto Outdated Show resolved Hide resolved
proto/cosmos/upgrade/query.proto Outdated Show resolved Hide resolved
@aaronc aaronc added A:automerge Automatically merge PR once all prerequisites pass. C:x/upgrade labels Jul 3, 2020
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

@mergify mergify bot merged commit 4459201 into master Jul 4, 2020
@mergify mergify bot deleted the am-5921-upgrade branch July 4, 2020 17:30
@clevinson clevinson added this to the v0.40 [Stargate] milestone Jul 9, 2020
@clevinson clevinson linked an issue Jul 9, 2020 that may be closed by this pull request
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query Protobuf Migration
4 participants