Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/evidence gRPC query service #6587

Closed
wants to merge 3 commits into from

Conversation

blushi
Copy link
Contributor

@blushi blushi commented Jul 3, 2020

Description

ref: #5921


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@aaronc aaronc mentioned this pull request Jul 3, 2020
43 tasks
@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #6587 into master will increase coverage by 0.36%.
The diff coverage is 51.11%.

@@            Coverage Diff             @@
##           master    #6587      +/-   ##
==========================================
+ Coverage   56.84%   57.20%   +0.36%     
==========================================
  Files         481      482       +1     
  Lines       28921    29030     +109     
==========================================
+ Hits        16441    16608     +167     
+ Misses      11314    11234      -80     
- Partials     1166     1188      +22     

@blushi blushi force-pushed the marie/5921-grpc-x-evidence branch from 421424e to d16bd1f Compare July 3, 2020 13:32
@blushi blushi closed this Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant