Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove alias.go from channel #6569

Merged
merged 3 commits into from
Jul 1, 2020
Merged

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Jul 1, 2020

Description

ref: #6311


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #6569 into master will increase coverage by 1.26%.
The diff coverage is 63.93%.

@@            Coverage Diff             @@
##           master    #6569      +/-   ##
==========================================
+ Coverage   55.60%   56.86%   +1.26%     
==========================================
  Files         457      482      +25     
  Lines       27440    28999    +1559     
==========================================
+ Hits        15257    16491    +1234     
- Misses      11083    11333     +250     
- Partials     1100     1175      +75     

@colin-axner colin-axner added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 1, 2020
@tac0turtle
Copy link
Member

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2020

Command refresh: success

@mergify mergify bot merged commit 2658175 into master Jul 1, 2020
@mergify mergify bot deleted the colin/6311-remove-alias-channel branch July 1, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants