Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove alias.go from 02-client #6542

Merged
merged 1 commit into from
Jun 30, 2020
Merged

remove alias.go from 02-client #6542

merged 1 commit into from
Jun 30, 2020

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Jun 30, 2020

Description

ref: #6311


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 30, 2020
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #6542 into master will increase coverage by 0.00%.
The diff coverage is 47.61%.

@@           Coverage Diff           @@
##           master    #6542   +/-   ##
=======================================
  Coverage   56.85%   56.85%           
=======================================
  Files         479      479           
  Lines       28796    28796           
=======================================
+ Hits        16371    16373    +2     
+ Misses      11268    11267    -1     
+ Partials     1157     1156    -1     

@colin-axner
Copy link
Contributor Author

anyone know why test-coverage-run-4 is reporting:

  with:
    file: ./coverage.txt
    fail_ci_if_error: true
  env:
    GIT_DIFF: 'simapp/app.go' 'x/ibc/02-client/genesis.go' 'x/ibc/02-client/handler.go' 'x/ibc/02-client/module.go' 'x/ibc/04-channel/keeper/packet.go' 'x/ibc/ante/ante.go' 'x/ibc/genesis_test.go' 'x/ibc/keeper/keeper.go' 'x/ibc/keeper/querier.go' 'x/ibc/types/codec.go' 'x/ibc/types/genesis.go'
    GIT_DIFF_FILTERED: 'simapp/app.go' 'x/ibc/02-client/genesis.go' 'x/ibc/02-client/handler.go' 'x/ibc/02-client/module.go' 'x/ibc/04-channel/keeper/packet.go' 'x/ibc/ante/ante.go' 'x/ibc/genesis_test.go' 'x/ibc/keeper/keeper.go' 'x/ibc/keeper/querier.go' 'x/ibc/types/codec.go' 'x/ibc/types/genesis.go'
/home/runner/work/_actions/codecov/codecov-action/v1/dist/index.js:20817
      throw error;
      ^

Error: connect ETIMEDOUT 35.199.43.247:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1129:14) {
  errno: 'ETIMEDOUT',
  code: 'ETIMEDOUT',
  syscall: 'connect',
  address: '35.199.43.247',
  port: 443
}

I'm gonna rerun but figured it should be mentioned

@mergify mergify bot merged commit 43b4f2f into master Jun 30, 2020
@mergify mergify bot deleted the colin/6311-alias branch June 30, 2020 10:37
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants