Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/gov: gRPC query Service #6491

Merged
merged 100 commits into from
Jul 16, 2020
Merged

x/gov: gRPC query Service #6491

merged 100 commits into from
Jul 16, 2020

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jun 23, 2020

Description

ref: #5921


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #6491 into master will increase coverage by 0.08%.
The diff coverage is 80.15%.

@@            Coverage Diff             @@
##           master    #6491      +/-   ##
==========================================
+ Coverage   59.85%   59.94%   +0.08%     
==========================================
  Files         512      513       +1     
  Lines       31303    31434     +131     
==========================================
+ Hits        18737    18842     +105     
- Misses      11143    11156      +13     
- Partials     1423     1436      +13     

@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2020

This pull request introduces 3 alerts when merging 85811e1 into 67d079e - view on LGTM.com

new alerts:

  • 3 for Useless assignment to local variable

@atheeshp atheeshp added the WIP label Jun 23, 2020
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍! I propose to keep the old comments on the struct fields.

proto/cosmos/gov/gov.proto Show resolved Hide resolved
proto/cosmos/gov/gov.proto Show resolved Hide resolved
proto/cosmos/gov/gov.proto Show resolved Hide resolved
proto/cosmos/gov/gov.proto Show resolved Hide resolved
proto/cosmos/gov/gov.proto Show resolved Hide resolved
proto/cosmos/gov/gov.proto Show resolved Hide resolved
@fedekunze fedekunze dismissed stale reviews from aaronc and sahith-narahari July 15, 2020 15:03

addressed

@fedekunze fedekunze added A:automerge Automatically merge PR once all prerequisites pass. C:x/gov labels Jul 15, 2020
@mergify mergify bot merged commit 2826990 into master Jul 16, 2020
@mergify mergify bot deleted the atheesh/5921-grpc-x-gov branch July 16, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/gov
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants