x:ibc: remove alias.go usage #6429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dauTT
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6429 +/- ##
=======================================
Coverage 55.72% 55.72%
=======================================
Files 465 465
Lines 27782 27782
=======================================
Hits 15481 15481
Misses 11197 11197
Partials 1104 1104 |
colin-axner
requested changes
Jun 12, 2020
simapp/app.go
Outdated
| @@ -30,6 +30,8 @@ import ( | |||
| transfer "github.com/cosmos/cosmos-sdk/x/ibc-transfer" | |||
| ibcclient "github.com/cosmos/cosmos-sdk/x/ibc/02-client" | |||
| port "github.com/cosmos/cosmos-sdk/x/ibc/05-port" | |||
| ibc24host "github.com/cosmos/cosmos-sdk/x/ibc/24-host" | |||
There was a problem hiding this comment.
ibc24host can just be host unless it conflicts with something (which I don't think it should) then it would be ibchost
alexanderbez
added
A:automerge
|
@Mergifyio refresh |
|
Command |
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* x:ibc: remove alias.go usage * Replace ibc24host with ibchost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes a sub task in #6311
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer