-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move codec/std to std #6085
Move codec/std to std #6085
Conversation
simapp/cmd/simcli/main.go
Outdated
@@ -2,6 +2,7 @@ package main | |||
|
|||
import ( | |||
"fmt" | |||
"github.com/cosmos/cosmos-sdk/std" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: grouping is incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does make format
do this automatically?
@@ -4,6 +4,7 @@ import ( | |||
"bufio" | |||
"errors" | |||
"fmt" | |||
"github.com/cosmos/cosmos-sdk/std" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
simapp/cmd/simd/main.go
Outdated
@@ -2,6 +2,7 @@ package main | |||
|
|||
import ( | |||
"encoding/json" | |||
"github.com/cosmos/cosmos-sdk/std" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
simapp/utils_test.go
Outdated
@@ -2,18 +2,18 @@ package simapp | |||
|
|||
import ( | |||
"fmt" | |||
"github.com/cosmos/cosmos-sdk/std" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
x/mint/simulation/decoder_test.go
Outdated
@@ -2,21 +2,21 @@ package simulation_test | |||
|
|||
import ( | |||
"fmt" | |||
"github.com/cosmos/cosmos-sdk/std" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -2,6 +2,7 @@ package simulation_test | |||
|
|||
import ( | |||
"fmt" | |||
"github.com/cosmos/cosmos-sdk/std" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -1,12 +1,12 @@ | |||
package staking_test | |||
|
|||
import ( | |||
"github.com/cosmos/cosmos-sdk/std" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -1,12 +1,12 @@ | |||
package keeper_test | |||
|
|||
import ( | |||
"github.com/cosmos/cosmos-sdk/std" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -2,6 +2,7 @@ package simulation_test | |||
|
|||
import ( | |||
"fmt" | |||
"github.com/cosmos/cosmos-sdk/std" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -1,11 +1,10 @@ | |||
package gov_test | |||
|
|||
import ( | |||
"github.com/cosmos/cosmos-sdk/std" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golangci] reported by reviewdog 🐶
File is not goimports
-ed (goimports)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK!
Description
This moves
codec/std
tostd
so that we have just onestd
package as discussed previously in #6034. It is expected to fail proto break checking as a package was renamed.For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)