Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup ibc-alpha #5945

Merged
merged 4 commits into from
Apr 7, 2020
Merged

cleanup ibc-alpha #5945

merged 4 commits into from
Apr 7, 2020

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Apr 7, 2020

Description

This PR undo changes from the ibc-alpha branch. This will likely be the final cleanup before merging to master.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. x/ibc labels Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #5945 into ibc-alpha will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           ibc-alpha    #5945   +/-   ##
==========================================
  Coverage      58.65%   58.66%           
==========================================
  Files            397      397           
  Lines          23338    23336    -2     
==========================================
  Hits           13690    13690           
+ Misses          8714     8713    -1     
+ Partials         934      933    -1     

@fedekunze
Copy link
Collaborator Author

There are a few non-IBC changes that affect other modules/pkgs. The most relevant is the following check:

	// x/<module>/keeper/keeper.go

	// set KeyTable if it has not already been set
	if !paramspace.HasKeyTable() {
		paramspace = paramspace.WithKeyTable(types.ParamKeyTable())
	}

Should we leave this check? @alexanderbez @cwgoes @jackzampolin @AdityaSripal ?

@fedekunze fedekunze marked this pull request as ready for review April 7, 2020 14:56
@fedekunze fedekunze added the R4R label Apr 7, 2020
@jackzampolin
Copy link
Member

I think we can kill that one @fedekunze

@fedekunze
Copy link
Collaborator Author

I think we can kill that one @fedekunze

@jackzampolin that means remove the changes?

@fedekunze
Copy link
Collaborator Author

kk I'll remove those too then

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze merged commit d0053c5 into ibc-alpha Apr 7, 2020
@fedekunze fedekunze deleted the cleanup-ibc-alpha branch April 7, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants