-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup ibc-alpha #5945
cleanup ibc-alpha #5945
Conversation
Codecov Report
@@ Coverage Diff @@
## ibc-alpha #5945 +/- ##
==========================================
Coverage 58.65% 58.66%
==========================================
Files 397 397
Lines 23338 23336 -2
==========================================
Hits 13690 13690
+ Misses 8714 8713 -1
+ Partials 934 933 -1 |
There are a few non-IBC changes that affect other modules/pkgs. The most relevant is the following check: // x/<module>/keeper/keeper.go
// set KeyTable if it has not already been set
if !paramspace.HasKeyTable() {
paramspace = paramspace.WithKeyTable(types.ParamKeyTable())
} Should we leave this check? @alexanderbez @cwgoes @jackzampolin @AdityaSripal ? |
I think we can kill that one @fedekunze |
@jackzampolin that means remove the changes? |
kk I'll remove those too then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Description
This PR undo changes from the ibc-alpha branch. This will likely be the final cleanup before merging to master.
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)