Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement --offline flag #5810

Merged
merged 31 commits into from
Mar 19, 2020
Merged

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Mar 16, 2020

Closes: #5448

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #5810 into master will decrease coverage by 0.2%.
The diff coverage is 31.25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5810      +/-   ##
=========================================
- Coverage   32.51%   32.3%   -0.21%     
=========================================
  Files         346     353       +7     
  Lines       39012   39461     +449     
=========================================
+ Hits        12684   12749      +65     
- Misses      25061   25439     +378     
- Partials     1267    1273       +6
Impacted Files Coverage Δ
x/auth/client/cli/tx_sign.go 0% <0%> (ø)
x/distribution/client/cli/tx.go 4.7% <0%> (ø) ⬆️
x/auth/client/cli/tx_multisign.go 0% <0%> (ø)
x/auth/client/tx.go 14.64% <0%> (ø) ⬆️
client/context/query.go 1.86% <0%> (ø) ⬆️
x/auth/client/cli/broadcast.go 84% <100%> (ø)
client/context/context.go 32.86% <75%> (+30.73%) ⬆️
x/auth/client/cli/encode.go 0% <0%> (ø)
... and 5 more

@jgimeno jgimeno marked this pull request as ready for review March 16, 2020 22:11
@jgimeno jgimeno self-assigned this Mar 16, 2020
client/context/context.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! I'd love some test cases - at least to avoid code coverage to get even lower. Plus, all query commands should all fail if --offline is passed

@tac0turtle tac0turtle changed the title Jonathan/5448 split generate only offline client: split generate only offline Mar 17, 2020
@jgimeno jgimeno changed the title client: split generate only offline Implementing --offline flag [WIP] Mar 17, 2020
@alessio alessio added WIP and removed R4R labels Mar 17, 2020
@jgimeno jgimeno reopened this Mar 18, 2020
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jgimeno! Let's get a branch open against Gaia that tests this out.

client/context/context.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
client/flags/flags.go Outdated Show resolved Hide resolved
client/flags/flags.go Outdated Show resolved Hide resolved
x/auth/client/cli/broadcast.go Outdated Show resolved Hide resolved
jgimeno and others added 4 commits March 18, 2020 17:19
client/context/context.go Outdated Show resolved Hide resolved
@jgimeno
Copy link
Contributor Author

jgimeno commented Mar 18, 2020

Here is the branch using this changes cosmos/gaia#326

@alessio
Copy link
Contributor

alessio commented Mar 18, 2020

FTR @jgimeno and I are testing the changes with gaia

@alexanderbez
Copy link
Contributor

Please merge when thorough testing has been performed @alessio.

@alessio
Copy link
Contributor

alessio commented Mar 18, 2020

Manual testing passed. We're now investigating into the drop of coverage stats.

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing left, otherwise this is good to go

@alessio alessio merged commit 8c7bb89 into master Mar 19, 2020
@alessio alessio deleted the jonathan/5448-split-generate-only-offline branch March 19, 2020 01:49
@alessio alessio changed the title Implementing --offline flag implement --offline flag Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make --generate-only also take --offline optionally
3 participants