Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS23 refactor #5710

Merged
merged 4 commits into from
Feb 27, 2020
Merged

ICS23 refactor #5710

merged 4 commits into from
Feb 27, 2020

Conversation

fedekunze
Copy link
Collaborator

Cleanup in preparation for proto migration

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze added x/ibc Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Feb 27, 2020
x/ibc/04-channel/types/msgs.go Outdated Show resolved Hide resolved
x/ibc/20-transfer/handler_test.go Show resolved Hide resolved
@fedekunze fedekunze merged commit 69d089c into ibc-alpha Feb 27, 2020
@fedekunze fedekunze deleted the fedekunze/ics23-refactor branch February 27, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants