Regen Network/Slashing protobuf #5627

anilcse · 2020-02-07T19:26:27Z

Closes: regen-network#19

Description

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Add base for migrating slashing module to protobuf

…g_protobuf_migration

…twork/cosmos-sdk into regen-network/slashing_protobuf

…ork/slashing_protobuf # Conflicts: # x/slashing/app_test.go

x/slashing/app_test.go

aaronc · 2020-02-17T17:03:34Z

simapp/codec.go

@@ -15,6 +16,7 @@ type AppCodec struct {
 	amino *codec.Codec

 	Params       *params.Codec
+	Slashing     *slashing.Codec


I do think we should have something more generic when modules don't actually do anything special with their codec. What do you think @alexanderbez ?

this file should be removed as the new design does not contain this struct. you can see here: https://github.com/cosmos/cosmos-sdk/blob/08502d6d98bff3872916f8b69cde2d255351d3fb/simapp/codec/codec.go

alexanderbez

@anilcse can you rebase off of the latest master please? Also, we need to remove the use of internal/ pkg (just bump everything up to the root; ref: #5646).

- Bump types, keeper to root

…ork/slashing_protobuf # Conflicts: # CHANGELOG.md

codecov · 2020-02-18T16:38:47Z

Codecov Report

Merging #5627 into master will decrease coverage by 0.62%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5627      +/-   ##
==========================================
- Coverage   39.42%   38.79%   -0.63%     
==========================================
  Files         326      327       +1     
  Lines       29014    29505     +491     
==========================================
+ Hits        11438    11446       +8     
- Misses      16386    16867     +481     
- Partials     1190     1192       +2

alexanderbez

Looks great! Just a few small nit picks 👍

alexanderbez · 2020-02-19T14:22:15Z

CHANGELOG.md

+for JSON encoding.
+  * The `Keeper` constructor now takes a `codec.Marshaler` instead of a concrete Amino codec. This exact type
+  provided is specified by `ModuleCdc`.
+* (distr) [\#5610](https://github.com/cosmos/cosmos-sdk/pull/5610) Migrate the `x/distribution` module to use Protocol Buffer for state


Why was this line added?

alexanderbez · 2020-02-19T14:40:07Z

x/slashing/types/codec.go

+	cdc.RegisterConcrete(MsgUnjail{}, "cosmos-sdk/MsgUnjail", nil)
+}
+
+type Codec struct {


We don't actually need a concrete type here anymore. See https://github.com/cosmos/cosmos-sdk/blob/master/x/distribution/types/codec.go for an example. You can just copy and modify.

alexanderbez · 2020-02-19T14:44:00Z

x/slashing/types/types.proto

+syntax = "proto3";
+package cosmos_sdk.x.slashing.v1;
+
+option go_package = "types";


I think some other modules do this wrong and need to be fixed. This should be github.com/cosmos/cosmos-sdk/x/slashing/types.

…ork/slashing_protobuf # Conflicts: # x/slashing/keeper/test_common.go

…twork/cosmos-sdk into regen-network/slashing_protobuf

alexanderbez

ACK 🎉

…ork/slashing_protobuf

anilcse added 8 commits February 7, 2020 23:56

Add protobuf def

76757e0

Add proto msg type for MsgUnJail

a0eaa7a

gofmt

0c6ca19

Merge pull request #21 from regen-network/vw/slashing_protobuf_migration

ab7fc9e

Add base for migrating slashing module to protobuf

Merge branch 'master' of github.com:cosmos/cosmos-sdk into vw/slashin…

fbf33e8

…g_protobuf_migration

Remove ModuleCodec

e8617dc

Merge branch 'regen-network/slashing_protobuf' of github.com:regen-ne…

3b7110b

…twork/cosmos-sdk into regen-network/slashing_protobuf

Add changelog

89b5834

tac0turtle added T: State Machine Breaking State machine breaking changes (impacts consensus). C:x/slashing WIP labels Feb 11, 2020

anilcse added 3 commits February 11, 2020 17:20

Fix naming

1cb8cc8

Fix undefined errors

2909f11

Add ValidatorSigningInfo protobuf implementation

c9ddfbd

alexanderbez mentioned this pull request Feb 11, 2020

Full Proto Encoding #5444

Closed

28 tasks

anilcse added 11 commits February 11, 2020 21:07

Revert unnecessary codec migration

d286da4

Add protobuf def

c601f08

Add proto msg type for MsgUnJail

af6b876

gofmt

5fb7442

Remove ModuleCodec

25f7f97

Add changelog

12111ae

Fix naming

af95b29

Fix undefined errors

ba3ee92

Add ValidatorSigningInfo protobuf implementation

d90bb3e

Revert unnecessary codec migration

2ca862f

Merge branch 'regen-network/slashing_protobuf' of github.com:regen-ne…

5395ce8

…twork/cosmos-sdk into regen-network/slashing_protobuf

anilcse force-pushed the regen-network/slashing_protobuf branch from 5395ce8 to d90bb3e Compare February 11, 2020 16:33

anilcse added 3 commits February 11, 2020 23:29

Add ValidatorSigningInfo proto codec

21b9cba

Fix keeper init in tests

5a5fd73

Add TODO

bdd9368

Merge branch 'master' of github.com:cosmos/cosmos-sdk into regen-netw…

53b45e0

…ork/slashing_protobuf # Conflicts: # x/slashing/app_test.go

golangcibot reviewed Feb 16, 2020

View reviewed changes

x/slashing/app_test.go Outdated Show resolved Hide resolved

anilcse added 2 commits February 16, 2020 23:42

Gofmt

5b9cc9f

Fix test-sim-import-export issue

ae52ace

anilcse requested a review from alexanderbez February 16, 2020 19:15

anilcse added 2 commits February 17, 2020 01:14

Fix gofmt

28e2556

Merge branch 'master' into regen-network/slashing_protobuf

7e34c0c

aaronc reviewed Feb 17, 2020

View reviewed changes

aaronc approved these changes Feb 17, 2020

View reviewed changes

alexanderbez suggested changes Feb 18, 2020

View reviewed changes

anilcse added 5 commits February 18, 2020 19:53

- Rebase to cosmos:master

e68f3f0

- Bump types, keeper to root

Fix typo

4360aee

Merge branch 'master' of github.com:cosmos/cosmos-sdk into regen-netw…

04ff0b5

…ork/slashing_protobuf # Conflicts: # CHANGELOG.md

Revert str conv

85b3a20

Fix gofmt

47c5fb5

anilcse requested a review from alexanderbez February 18, 2020 15:06

Merge branch 'master' into regen-network/slashing_protobuf

65b5622

alexanderbez suggested changes Feb 19, 2020

View reviewed changes

anilcse added 6 commits February 19, 2020 20:34

Fix review changes

9e7b6ed

Merge branch 'master' of github.com:cosmos/cosmos-sdk into regen-netw…

a836c0e

…ork/slashing_protobuf # Conflicts: # x/slashing/keeper/test_common.go

Remove unused codec alias

db992df

Merge branch 'regen-network/slashing_protobuf' of github.com:regen-ne…

73271ff

…twork/cosmos-sdk into regen-network/slashing_protobuf

Revert

e5f10e1

fix import

4c5e070

alexanderbez approved these changes Feb 19, 2020

View reviewed changes

Merge branch 'master' of github.com:cosmos/cosmos-sdk into regen-netw…

44559dd

…ork/slashing_protobuf

alexanderbez merged commit 883c1a2 into cosmos:master Feb 20, 2020

ryanchristo deleted the regen-network/slashing_protobuf branch December 12, 2022 18:15

larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023

Merge PR cosmos#5627: Regen Network/Slashing protobuf

ddb342b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Regen Network/Slashing protobuf #5627

Regen Network/Slashing protobuf #5627

anilcse commented Feb 7, 2020 •

edited

Loading

aaronc Feb 17, 2020

tac0turtle Feb 17, 2020

alexanderbez left a comment

codecov bot commented Feb 18, 2020

alexanderbez left a comment

alexanderbez Feb 19, 2020

alexanderbez Feb 19, 2020

alexanderbez Feb 19, 2020

alexanderbez left a comment

Regen Network/Slashing protobuf #5627

Regen Network/Slashing protobuf #5627

Conversation

anilcse commented Feb 7, 2020 • edited Loading

Description

aaronc Feb 17, 2020

Choose a reason for hiding this comment

tac0turtle Feb 17, 2020

Choose a reason for hiding this comment

alexanderbez left a comment

Choose a reason for hiding this comment

codecov bot commented Feb 18, 2020

Codecov Report

alexanderbez left a comment

Choose a reason for hiding this comment

alexanderbez Feb 19, 2020

Choose a reason for hiding this comment

alexanderbez Feb 19, 2020

Choose a reason for hiding this comment

alexanderbez Feb 19, 2020

Choose a reason for hiding this comment

alexanderbez left a comment

Choose a reason for hiding this comment

anilcse commented Feb 7, 2020 •

edited

Loading