Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IBC membership verification #5335

Closed
wants to merge 6 commits into from
Closed

Update IBC membership verification #5335

wants to merge 6 commits into from

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Nov 21, 2019 •
edited
Loading

Closes #5312
Ref: cosmos/ibc#293

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes
Copy link
Contributor

cwgoes commented Nov 25, 2019

@fedekunze Were my answers in cosmos/ibc#293 (comments) clear?

@cwgoes cwgoes mentioned this pull request Nov 26, 2019
Closed
34 tasks
@fedekunze fedekunze added this to the IBC Implementation milestone Dec 10, 2019
@alexanderbez alexanderbez mentioned this pull request Dec 10, 2019
Closed
30 tasks
@fedekunze
Copy link
Collaborator Author

I will update this with a new PR once ICS06 and ICS07 are completed. Closing

@fedekunze fedekunze closed this Jan 2, 2020
@fedekunze fedekunze deleted the fedekunze/5312-update-verification branch January 2, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin Awaiting requested review from jackzampolin jackzampolin will be requested when the pull request is marked ready for review jackzampolin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
IBC 1.0 [Implementation]
Development

Successfully merging this pull request may close these issues.
2 participants
@fedekunze @cwgoes