Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check denom #4600

Merged
merged 4 commits into from
Jun 20, 2019
Merged

Fix check denom #4600

merged 4 commits into from
Jun 20, 2019

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Jun 20, 2019

closes #4598

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ☕️

Might be worth adding a simple test case for this though.

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending test case

Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. THANKS
if there ever ends up being another check common to delegation/redelegation/undelegation we should create a "validate basic" function for all handlers to run through. not there yet though!

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #4600 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #4600      +/-   ##
==========================================
+ Coverage   52.76%   52.79%   +0.03%     
==========================================
  Files         264      264              
  Lines       16464    16468       +4     
==========================================
+ Hits         8687     8695       +8     
+ Misses       7128     7126       -2     
+ Partials      649      647       -2

@alessio
Copy link
Contributor

alessio commented Jun 20, 2019

Looks even better now 👍

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redelegate and Unbond never check denomination in transaction
4 participants