-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix check denom #4600
Fix check denom #4600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ☕️
Might be worth adding a simple test case for this though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending test case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. THANKS
if there ever ends up being another check common to delegation/redelegation/undelegation we should create a "validate basic" function for all handlers to run through. not there yet though!
Codecov Report
@@ Coverage Diff @@
## master #4600 +/- ##
==========================================
+ Coverage 52.76% 52.79% +0.03%
==========================================
Files 264 264
Lines 16464 16468 +4
==========================================
+ Hits 8687 8695 +8
+ Misses 7128 7126 -2
+ Partials 649 647 -2 |
Looks even better now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
closes #4598
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: