-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.33.1 zero export bugfix #3999
Conversation
Codecov Report
@@ Coverage Diff @@
## release/v0.33.1 #3999 +/- ##
===================================================
- Coverage 60.89% 60.85% -0.04%
===================================================
Files 192 192
Lines 14288 14289 +1
===================================================
- Hits 8700 8696 -4
- Misses 5021 5026 +5
Partials 567 567 |
Do we need a pendinglog entry here or a changelog entry here @alessio? |
We would want a changelog entry in the actual release |
Pending entry is fine. Who handle the release will generate the new changelog I guess, don't they? @jackzampolin @alexanderbez |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
@@ -0,0 +1 @@ | |||
#3656 distribution delegation zero export bugfix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hang on, 3656 is #3656. Is it correct to link the two?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going directly into a hotfix release. I think therefor there should be no pending log entry, but rather a direct change log entry pointing to the PR #3999 instead of the original PR.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: