Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gometalinter -> golangci-lint migration #3933

Merged
merged 15 commits into from
Mar 19, 2019
Merged

gometalinter -> golangci-lint migration #3933

merged 15 commits into from
Mar 19, 2019

Commits on Mar 18, 2019

  1. gometalinter -> golangci-lint migration 

    {,scripts/}Makefile:
- Remove gometalinter, install golangci-lint.
- Remove distinction between tools and devtools.
  Just tools is enough.
- test_lint -> lint
  Migrating away from underscore separated names.
- Remove unnecessary targets.
- Drop tendermint/lint. Incompatbile with golangci-lint
  and no longer necessary anyway.

Port tools/gometalinter.json to .golangci.yml
Update CircleCI config accordingly.

Closes: #3896
    @alessio
    alessio committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    8df582c View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. Update client/rpc/status.go 

    Co-Authored-By: alessio <[email protected]>
    @rigelrozanski @alessio
    rigelrozanski and alessio authored Mar 19, 2019
    Configuration menu
    Copy the full SHA
    ca376bd View commit details
    Browse the repository at this point in the history

  2. couldn't to could not

    @alessio
    alessio committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    9c4a074 View commit details
    Browse the repository at this point in the history

  3. Fix misleading message in go-mod-cache 

    dep -> go mod migration leftover
    @alessio
    alessio committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    877c91a View commit details
    Browse the repository at this point in the history

  4. Let's not carry install-golangci.sh with us, just download the instal… 

    …ler and verify it
    @alessio
    alessio committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    367c5a3 View commit details
    Browse the repository at this point in the history

  5. Update go.sum

    @alessio
    alessio committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    bd033d0 View commit details
    Browse the repository at this point in the history

  6. Include tools in .PHONY

    @alessio
    alessio committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    1a510b5 View commit details
    Browse the repository at this point in the history

  7. Make lint depend on golangci-lint only

    @alessio
    alessio committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    b226049 View commit details
    Browse the repository at this point in the history

  8. Fix build

    @alessio
    alessio committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    70da636 View commit details
    Browse the repository at this point in the history

  9. Revert "Make lint depend on golangci-lint only" 

    This reverts commit b226049.
    @alessio
    alessio committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    4970e6a View commit details
    Browse the repository at this point in the history

  10. What happens if I don't checkout VCS before running lint?

    @alessio
    alessio committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    471f8c0 View commit details
    Browse the repository at this point in the history

  11. Revert "What happens if I don't checkout VCS before running lint?" 

    This reverts commit 471f8c0.
    @alessio
    alessio committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    bb80138 View commit details
    Browse the repository at this point in the history

  12. Make ci-target to avoid download tools twice

    @alessio
    alessio committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    add88ab View commit details
    Browse the repository at this point in the history

  13. Attempt to introduce go modules cache

    @alessio
    alessio committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    b09c76c View commit details
    Browse the repository at this point in the history

  14. Run tests with -mod=readonly

    @alessio
    alessio committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    0712cde View commit details
    Browse the repository at this point in the history