Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate genesis before running gentx #3927

Merged
merged 2 commits into from
Mar 20, 2019

Conversation

sabau
Copy link
Contributor

@sabau sabau commented Mar 18, 2019

  • Closes run validate genesis before running gentx and return error #3825

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Signed-off-by: Karoly Albert Szabo <[email protected]>
@sabau sabau changed the title Validate genesis before running gentx [R4R] Validate genesis before running gentx Mar 18, 2019
@sabau sabau changed the title [R4R] Validate genesis before running gentx Validate genesis before running gentx Mar 18, 2019
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #3927 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3927   +/-   ##
========================================
  Coverage    60.26%   60.26%           
========================================
  Files          196      196           
  Lines        14615    14615           
========================================
  Hits          8808     8808           
  Misses        5214     5214           
  Partials       593      593

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PENDING too?

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a mention in the Gaia stanza of changelog's bugfixes or improvements section: sdkch add gaia bugfixes

Signed-off-by: Karoly Albert Szabo <[email protected]>
@sabau sabau requested a review from alessio March 20, 2019 12:18
@sabau
Copy link
Contributor Author

sabau commented Mar 20, 2019

My bad, I haven't pushed it

@alessio alessio merged commit 7438a65 into develop Mar 20, 2019
@alessio alessio deleted the sabau/3825-validate-genesis-gentx branch March 20, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants