R4R: Reconcile DecCoin/s API with Coin/s API #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
requested review from
alessio,
jackzampolin,
rigelrozanski and
cwgoes
added 10 commits
February 11, 2019 16:02
alexanderbez
commented
Feb 12, 2019
Codecov Report
@@ Coverage Diff @@
## develop #3607 +/- ##
==========================================
- Coverage 60.92% 60.73% -0.2%
==========================================
Files 188 188
Lines 14084 14143 +59
==========================================
+ Hits 8581 8590 +9
- Misses 4959 5008 +49
- Partials 544 545 +1 |
alexanderbez
changed the title
cwgoes
suggested changes
Feb 14, 2019
types/dec_coin.go
Outdated
| // IsLT returns true if they are the same type and the receiver is | ||
| // a smaller value. | ||
| func (coin DecCoin) IsLT(other DecCoin) bool { | ||
| return coin.SameDenomAs(other) && coin.Amount.LT(other.Amount) |
There was a problem hiding this comment.
ditto on panicking with a different denom
There was a problem hiding this comment.
I think this function is also never used, maybe we should just delete it
|
Updated @cwgoes |
added 2 commits
February 14, 2019 11:37
Responded to comment responses. |
cwgoes
approved these changes
Feb 14, 2019
melekes
approved these changes
Feb 15, 2019
| @@ -485,6 +487,15 @@ var ( | |||
| reDecCoin = regexp.MustCompile(fmt.Sprintf(`^(%s)%s(%s)$`, reDecAmt, reSpc, reDnm)) | |||
| ) | |||
|
|
|||
| func validateDenom(denom string) { | |||
| if len(denom) < 3 || len(denom) > 16 { | |||
There was a problem hiding this comment.
look like magic numbers to me
There was a problem hiding this comment.
Hmm how so? This is just for validation, we can pick any consistent length range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, this does not reconcile the DecCoin/s API via an interface as that cause a larger headache. I believe starting to simply reconcile the APIs piecewise is a great first approach.
closes: #3311
closes: #3614
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: