R4R: Improve SDK Error Messages & Allow Unicode #3604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
requested review from
alessio,
faboweb,
jackzampolin and
fedekunze
alexanderbez
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
alexanderbez
changed the title
| enc.SetEscapeHTML(false) | ||
|
|
||
| if err := enc.Encode(jsonErr); err != nil { | ||
| panic(errors.Wrap(err, "failed to encode ABCI error log")) |
|
Will this return an actual JSON instead of |
|
@faboweb I don't follow. This improves the error messages and displays unicode (in the JSON response). e.g. |
jackzampolin
approved these changes
Feb 11, 2019
Codecov Report
@@ Coverage Diff @@
## develop #3604 +/- ##
===========================================
- Coverage 61.46% 61.44% -0.02%
===========================================
Files 186 186
Lines 13981 13990 +9
===========================================
+ Hits 8593 8596 +3
- Misses 4841 4847 +6
Partials 547 547 |
rigelrozanski
approved these changes
Feb 11, 2019
jbibla
reviewed
Feb 19, 2019
| stringifiedJSON := string(bz) | ||
| return stringifiedJSON | ||
|
|
||
| return strings.TrimSpace(buff.String()) |
There was a problem hiding this comment.
the @cosmos/cosmos-ui was hoping for something more like:
{
"codespace": "sdk",
"code": 10,
"message": "You are trying to send more stake than you own."
}
(from #3601)
There was a problem hiding this comment.
is this the expected response?
There was a problem hiding this comment.
Thanks for following up @jbibla! Are you saying you wish it to be pretty JSON and indented? It already is JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<)Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: