R4R: Increasing test coverage - First Pass #3517

jleni · 2019-02-06T15:06:34Z

This PR includes a first group of additional tests. Other PRs will be submitted afterwards.

Related to #2004

Wrote tests
Updated relevant documentation (docs/)
Added entries in PENDING.md with issue #
rereviewed Files changed in the github PR explorer

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Makefile

client/context/context.go

.gitignore

client/context/broadcast.go

client/input.go

client/keys/add.go

client/keys/add_test.go

client/keys/update.go

crypto/ledger_mock.go

crypto/ledger_notavail.go

alessio

So far so good

jackzampolin · 2019-02-08T01:51:57Z

Moving this back to WIP

jleni · 2019-02-08T05:46:53Z

Moving this back to WIP

Yep. I will squash this a bit too, so I remove Alessio's already merged commits.

client/keys/list.go

jackzampolin

Great tests. Want to see a follow up to this that adds stdout and stdin to context and applies that to the codebase.

jleni · 2019-02-08T18:27:55Z

Great tests. Want to see a follow up to this that adds stdout and stdin to context and applies that to the codebase.

Yep, the issue is here. #3558

jleni · 2019-02-08T18:41:17Z

grr.. circleci is not doing well today :(

alessio · 2019-02-08T18:45:37Z

Has it ever done well? It is awful

…

On Fri, Feb 8, 2019 at 10:41 AM Juan Leni ***@***.***> wrote: grr.. circleci is not doing well today :( — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#3517 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAN_7I5iTEGHp7X_1svgsaQGBSj2zlFpks5vLcTOgaJpZM4albf_> .

-- Alessio Treglia | [email protected] 0416 0004 A827 6E40 BB98 90FB E8A4 8AE5 311D 765A

alexanderbez

This looks great @jleni -- I just have a few remarks/questions.

client/input.go

client/keys/add.go

client/keys/delete.go

client/keys/show.go

client/keys/utils.go

jleni · 2019-02-08T19:07:19Z

@alexanderbez ready 👍

jackzampolin · 2019-02-08T19:37:21Z

@jleni still failing a test 🙃

Squashed commits: [72934fc7] Adding tests (WIP) [0a342270] Adding additional tests

Squashed commits: [e72a3b57] Additional tests [643ca3f8] revert rename [9100fe61] Add more tests, remove linter warnings [23f092bb] more tests

Adjusting to new keybase handling Better test + redirecting inputs Updating delete test to use fake user input Clean up linters

Add more tests, remove linter warnings revert rename Additional tests fix linter issue

Co-Authored-By: jleni <[email protected]>

jleni · 2019-02-08T20:20:31Z

@jleni still failing a test 🙃

yes, reverting the "defensive" checks resulted in test failing :)

fixed and rebased.

jleni requested review from cwgoes, ebuchman and rigelrozanski as code owners February 6, 2019 15:06

jleni force-pushed the tests/coverage branch from 266fc8d to 76af126 Compare February 6, 2019 20:36

jleni changed the title ~~WIP: Increasing test coverage~~ WIP: Increasing test coverage - First Pass Feb 7, 2019

jleni force-pushed the tests/coverage branch 2 times, most recently from 0036a69 to 60b5658 Compare February 7, 2019 07:28

jleni changed the title ~~WIP: Increasing test coverage - First Pass~~ R4R: Increasing test coverage - First Pass Feb 7, 2019

jleni added T: Tests Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. ready-for-review labels Feb 7, 2019

jleni requested review from alessio, alexanderbez and jackzampolin February 7, 2019 09:22

alexanderbez reviewed Feb 7, 2019

View reviewed changes

Makefile Outdated Show resolved Hide resolved

client/context/context.go Outdated Show resolved Hide resolved