Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Remove unimplemented gaiacli init command #3156

Merged
merged 3 commits into from
Dec 19, 2018

Conversation

jackzampolin
Copy link
Member

Title

  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #3156 into develop will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #3156      +/-   ##
==========================================
- Coverage    55.05%     55%   -0.06%     
==========================================
  Files          133     132       -1     
  Lines         9438    9425      -13     
==========================================
- Hits          5196    5184      -12     
  Misses        3922    3922              
+ Partials       320     319       -1

@zramsay zramsay mentioned this pull request Dec 18, 2018
26 tasks
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remark, but otherwise LGTM.

// cli version REST handler endpoint
func CLIVersionRequestHandler(w http.ResponseWriter, r *http.Request) {
v := version.GetVersion()
w.Write([]byte(v))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should return a simple JSON response here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we should. Like that idea.

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true that this command doesn't do anything at the moment, but I think it is intended to - definitely, we want some way for lite clients to choose a root-of-trust explicitly for verification. Maybe this isn't the way, but I wonder if we just haven't done the implementation yet.

cc @ebuchman do you have more context here?

@jackzampolin
Copy link
Member Author

@cwgoes I don't think that feature is anywhere close to done so we can easily add it back. This has been dead code confusing users and cluttering up the CLI for a while.

@cwgoes
Copy link
Contributor

cwgoes commented Dec 19, 2018

@cwgoes I don't think that feature is anywhere close to done so we can easily add it back. This has been dead code confusing users and cluttering up the CLI for a while.

OK - I split my concerns into an issue, I do think this merits discussion but we can remove the command for now.

@jackzampolin jackzampolin merged commit 0360b12 into develop Dec 19, 2018
@jackzampolin jackzampolin deleted the jack/remove-cli-init branch December 19, 2018 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants