Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Add shorthand flag to address output on gaiacli keys show and update docs #2987

Merged
merged 5 commits into from
Dec 4, 2018

Conversation

jackzampolin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #2987 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2987   +/-   ##
========================================
  Coverage    55.53%   55.53%           
========================================
  Files          120      120           
  Lines         8494     8494           
========================================
  Hits          4717     4717           
  Misses        3455     3455           
  Partials       322      322

@alexanderbez
Copy link
Contributor

Hmmm, is this completely necessary?

@jackzampolin
Copy link
Member Author

@alexanderbez it allows users to type gaiacli keys show foo -a instead of gaiacli keys show foo --address. Considering the point of the feature is to make it easy to type I think this is a worthwhile change.

@alexanderbez
Copy link
Contributor

Ok, cool. We don't have a large surface area for shorthand usage because of our ample list of CLI flags, but I think this makes sense.

client/keys/show.go Outdated Show resolved Hide resolved
Co-Authored-By: jackzampolin <[email protected]>
@jackzampolin
Copy link
Member Author

I just need a couple of approvals here!

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails and also fails locally; I don't think you can use a two-character shorthand flag.

@jackzampolin
Copy link
Member Author

Completely missed that one @cwgoes. Fixed and R4M again.

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@cwgoes cwgoes merged commit 07b0ad3 into develop Dec 4, 2018
@cwgoes cwgoes deleted the jack/add-address-flag branch December 4, 2018 16:38
mircea-c pushed a commit that referenced this pull request Dec 5, 2018
…show and update docs

* Add shorthand flag to address output on gaiacli keys show

* Update docs and add PENDING

* Update client/keys/show.go

Co-Authored-By: jackzampolin <[email protected]>

* pk -> p
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants