Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Make simulator operations predetermined #2897

Closed
wants to merge 85 commits into from

Conversation

jaekwon
Copy link
Contributor

@jaekwon jaekwon commented Nov 25, 2018

I'm trying to let us skip operations/msgs from handlers without messing up the following operations, as in...

var i = 0
 func NewHandler(k keeper.Keeper) sdk.Handler {
        return func(ctx sdk.Context, msg sdk.Msg) sdk.Result {
               if ctx.BlockHeight() == <BLOCK_WITH_SUSPECTED_TX> {
                       i += 1
                       if i == <SUSPECTED_TX_NUMBER> {
                               return sdk.ErrTxDecode("just exit").Result()
                       }
               }
        ...

@codecov
Copy link

codecov bot commented Nov 25, 2018

Codecov Report

❗ No coverage uploaded for pull request base (rigel/blockly-mint@5ddd549). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##             rigel/blockly-mint    #2897   +/-   ##
=====================================================
  Coverage                      ?   56.83%           
=====================================================
  Files                         ?      120           
  Lines                         ?     8319           
  Branches                      ?        0           
=====================================================
  Hits                          ?     4728           
  Misses                        ?     3272           
  Partials                      ?      319

@jaekwon jaekwon changed the base branch from rigel/blockly-mint to develop November 26, 2018 12:15
@jaekwon
Copy link
Contributor Author

jaekwon commented Nov 26, 2018

Closing this PR, preferring #2900

@jaekwon jaekwon closed this Nov 26, 2018
@cwgoes cwgoes deleted the jae/simulator_more_deterministic branch November 26, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants