Fixed typos #23598
Fixed typos #23598
Conversation
petryshkaCODE
requested review from
a team,
julienrbrt and
JulianToledano
as code owners
📝 WalkthroughWalkthroughThe changes update documentation URLs to correct the repository reference from “cips” to “chips” for Off-chain CIP and account standardization. Additionally, a test file has a variable rename from Changes
Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/rfc/rfc-004-accounts.md (1)
86-86: LGTM! Repository URL updated correctly.The repository URL has been updated from
cipstochips, which aligns with the PR objectives.Consider adding a comma after the introductory phrase "For this reason":
-With `x/accounts` allowing a modular api there becomes a need for standardization of accounts or the interfaces wallets and other clients should expect to use. For this reason we will be using the [`CIP` repo](https://github.com/cosmos/chips) in order to standardize interfaces in order for wallets to know what to expect when interacting with accounts. +With `x/accounts` allowing a modular api there becomes a need for standardization of accounts or the interfaces wallets and other clients should expect to use. For this reason, we will be using the [`CIP` repo](https://github.com/cosmos/chips) in order to standardize interfaces in order for wallets to know what to expect when interacting with accounts.🧰 Tools
🪛 LanguageTool
[typographical] ~86-~86: Use a comma after an introductory phrase.
Context: ...and other clients should expect to use. For this reason we will be using the [CIPrepo](https...(COMMA_INTRODUCTORY_WORDS_PHRASES)
[style] ~86-~86: Consider a shorter alternative to avoid wordiness.
Context: ... repo](https://github.com/cosmos/chips) in order to standardize interfaces in order for wal...(IN_ORDER_TO_PREMIUM)
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
client/v2/README.md(1 hunks)docs/rfc/rfc-004-accounts.md(1 hunks)tests/integration/v2/distribution/grpc_query_test.go(10 hunks)
✅ Files skipped from review due to trivial changes (1)
- client/v2/README.md
🧰 Additional context used
📓 Path-based instructions (2)
tests/integration/v2/distribution/grpc_query_test.go (3)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"
Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
docs/rfc/rfc-004-accounts.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
🪛 LanguageTool
docs/rfc/rfc-004-accounts.md
[typographical] ~86-~86: Use a comma after an introductory phrase.
Context: ...and other clients should expect to use. For this reason we will be using the [CIP repo](https...
(COMMA_INTRODUCTORY_WORDS_PHRASES)
[style] ~86-~86: Consider a shorter alternative to avoid wordiness.
Context: ... repo](https://github.com/cosmos/chips) in order to standardize interfaces in order for wal...
(IN_ORDER_TO_PREMIUM)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
| @@ -207,7 +207,7 @@ func TestGRPCValidatorSlashes(t *testing.T) { | |||
|
|
|||
| var ( | |||
| req *types.QueryValidatorSlashesRequest | |||
| expRes *types.QueryValidatorSlashesResponse | |||
| express *types.QueryValidatorSlashesResponse | |||
There was a problem hiding this comment.
Revert variable name change from expRes to express.
The variable name change from expRes to express appears to be a misstep. expRes is a common abbreviation for "expected result" in test files, while express doesn't convey the same meaning and could be misleading.
Apply this diff to revert the variable name:
-express := &types.QueryValidatorSlashesResponse{
+expRes := &types.QueryValidatorSlashesResponse{-express = &types.QueryValidatorSlashesResponse{}
+expRes = &types.QueryValidatorSlashesResponse{}-express = &types.QueryValidatorSlashesResponse{Pagination: &query.PageResponse{}}
+expRes = &types.QueryValidatorSlashesResponse{Pagination: &query.PageResponse{}}-express = &types.QueryValidatorSlashesResponse{Pagination: &query.PageResponse{}}
+expRes = &types.QueryValidatorSlashesResponse{Pagination: &query.PageResponse{}}-express = &types.QueryValidatorSlashesResponse{
+expRes = &types.QueryValidatorSlashesResponse{-express = &types.QueryValidatorSlashesResponse{
+expRes = &types.QueryValidatorSlashesResponse{-express = &types.QueryValidatorSlashesResponse{
+expRes = &types.QueryValidatorSlashesResponse{-express := &types.QueryDelegationRewardsResponse{
+expRes := &types.QueryDelegationRewardsResponse{-assert.DeepEqual(t, express, rewards)
+assert.DeepEqual(t, expRes, rewards)Also applies to: 223-223, 236-236, 249-249, 268-268, 289-289, 310-310, 470-470, 531-531
Changes
/docs/rfc/rfc-004-accounts.mdcipstochips(Line 86)/client/v2/README.mdcipstochips(Line 293)/tests/integration/v2/distribution/grpc_query_test.goexpRestoexpress(Line 223)Purpose
Summary by CodeRabbit
Documentation
Tests