Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: split system tests in two job #22080

Merged
merged 1 commit into from
Oct 3, 2024
Merged

ci: split system tests in two job #22080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ jobs:
name: "${{ github.sha }}-e2e-coverage"
path: ./tests/e2e-profile.out

test-system:
test-system: # v2 system tests are in v2-test.yml
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -183,16 +183,6 @@ jobs:
name: "testnet-setup"
path: ./systemtests/testnet/
retention-days: 3
- name: system tests v2
if: env.GIT_DIFF
run: |
COSMOS_BUILD_OPTIONS=v2 make test-system
- uses: actions/upload-artifact@v3
if: failure()
with:
name: "testnet-setup"
path: ./systemtests/testnet/
retention-days: 3

repo-analysis:
runs-on: ubuntu-latest
Expand Down
40 changes: 40 additions & 0 deletions .github/workflows/v2-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,43 @@ jobs:
if: env.GIT_DIFF
run: |
cd server/v2/cometbft && go test -mod=readonly -race -timeout 30m -tags='ledger test_ledger_mock'

test-system-v2:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-tags: true
- uses: actions/setup-go@v5
with:
go-version: "1.23"
check-latest: true
cache: true
cache-dependency-path: |
simapp/v2/go.sum
systemtest/go.sum
- uses: technote-space/[email protected]
id: git_diff
with:
PATTERNS: |
**/*.go
go.mod
go.sum
**/go.mod
**/go.sum
**/Makefile
Makefile
- name: Install musl lib for simd (docker) binary
if: env.GIT_DIFF
run: |
sudo apt-get install -y musl
- name: system tests v2
if: env.GIT_DIFF
run: |
COSMOS_BUILD_OPTIONS=v2 make test-system
Comment on lines +142 to +145
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

LGTM: System tests execution step is well-configured

The system tests execution step is correctly conditioned on detected changes and uses a Makefile target, which is a good practice for managing complex test commands.

However, the purpose of the COSMOS_BUILD_OPTIONS=v2 environment variable is not documented. It is used in scripts/init-simapp-v2.sh to ensure SIMD_BIN is set. Please consider adding comments or documentation to explain its significance for future maintainers.

🔗 Analysis chain

LGTM: System tests execution step is well-configured

The system tests execution step is correctly conditioned on detected changes and uses a Makefile target, which is a good practice for managing complex test commands.

Could you please clarify the purpose of the COSMOS_BUILD_OPTIONS=v2 environment variable? It would be helpful to add a comment explaining its significance for future maintainers.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify if there's any documentation or comments about COSMOS_BUILD_OPTIONS
rg -i "COSMOS_BUILD_OPTIONS.*v2" --type md

Length of output: 44

Script:

#!/bin/bash
# Search for occurrences of COSMOS_BUILD_OPTIONS=v2 in code files excluding documentation
rg -i "COSMOS_BUILD_OPTIONS\s*=\s*v2" --type yaml --type yml --type sh --type bash --type make

Length of output: 124

Script:

#!/bin/bash
# Search for occurrences of COSMOS_BUILD_OPTIONS=v2 in code files excluding documentation
rg -i "COSMOS_BUILD_OPTIONS\s*=\s*v2" --type yaml --type sh --type bash --type make

Length of output: 114

Script:

#!/bin/bash
# Search for occurrences of COSMOS_BUILD_OPTIONS=v2 in code files excluding documentation
rg -i "COSMOS_BUILD_OPTIONS\s*=\s*v2" --type yaml --type sh --type make

Length of output: 230

- uses: actions/upload-artifact@v3
if: failure()
with:
name: "testnet-setup"
path: ./systemtests/testnet/
retention-days: 3
Loading