chore(x/authz)!: Remove account keeper dependency

[facundomedica]

Description

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features

  • Introduced a RevokeAll method for revoking all grants simultaneously.
  • Implemented a limit on the number of grants pruned per block.

• Improvements

  • Enhanced address handling with a new address codec for authorization processes.

• Bug Fixes

  • Resolved issues with transaction event queries ensuring responses contain only UTF-8 characters.

• Documentation

  • Updated changelog to reflect new features, improvements, and breaking changes in the x/authz module.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes involve modifications to the initialization and handling of the AuthzKeeper and related components within the x/authz module. Key alterations include replacing the AccountKeeper with an AddressCodec, updating address conversion methods, and removing mock dependencies. The overall structure and functionality of the authorization system remain intact while streamlining address handling and improving the clarity of the codebase.

Changes

File(s)	Change Summary
simapp/app.go	Modified NewSimApp to initialize AuthzKeeper with signingCtx.AddressCodec() instead of app.AuthKeeper.
x/authz/CHANGELOG.md	Updated to reflect new features, improvements, breaking changes, and bug fixes including the introduction of RevokeAll method and changes to NewKeeper.
x/authz/expected_keepers.go	Removed AccountKeeper interface and its methods from the authz package.
x/authz/keeper/genesis.go	Updated address conversion methods in InitGenesis and ExportGenesis to use k.addrCdc instead of k.authKeeper.AddressCodec().
x/authz/keeper/genesis_test.go	Removed gomock dependency and mock account keeper setup; introduced addresscodec for address handling.
x/authz/keeper/grpc_query.go	Updated address conversion in grant querying methods to use k.addrCdc instead of k.authKeeper.AddressCodec().
x/authz/keeper/grpc_query_test.go	Replaced accountKeeper.AddressCodec() with addrCdc for address conversions in test cases.
x/authz/keeper/keeper.go	Replaced authKeeper field with addrCdc in Keeper struct; updated NewKeeper to accept address.Codec.
x/authz/keeper/keeper_test.go	Integrated new address codec and removed mock account keeper; updated test cases to utilize addrCdc.
x/authz/keeper/msg_server.go	Updated address conversion in Grant, Revoke, RevokeAll, and Exec methods to use k.addrCdc.
x/authz/keeper/msg_server_test.go	Replaced accountKeeper.AddressCodec() with addrCdc for address handling in tests.
x/authz/module/abci_test.go	Removed gomock dependency; utilized addrCdc for address conversions in tests.
x/authz/module/depinject.go	Updated ModuleInputs to replace AccountKeeper with AddressCodec; modified ProvideModule function accordingly.
x/authz/testutil/expected_keepers_mocks.go	Removed MockAccountKeeper and its methods from the testutil package.

Possibly related PRs

• refactor: remove consensus as a imported type in modules  #21480: Modifications to the NewKeeper function in simapp/app.go related to keeper initialization.
• fix(sims): TestAppSimulationAfterImport and legacy proposal handling #21800: Changes to the evidenceKeeper initialization in simapp/app.go, relevant to keeper configuration.
• refactor(x/evidence): accept address codec in constructor  #21859: Modifications to the evidenceKeeper with a focus on enhancing dependencies.
• feat: introduce x/validate and split x/auth/tx/config #21822: Introduction of the x/validate module, reflecting broader changes in module interactions.
• refactor(x/mint): remove staking as a required module #21858: Refactor of the mint module to simplify functionality and dependencies.
• refactor: simplify collected metrics #21963: Simplification of telemetry metrics collection, aligning with the objectives of enhancing module interactions.

Suggested labels

C:x/accounts, C:x/evidence, C:x/upgrade, backport/v0.52.x

Suggested reviewers

• julienrbrt
• akhilkumarpilli
• kocubinski
• sontrinh16
• testinginprod
• lucaslopezf

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.