Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use the right link for app.go #21585

Merged
merged 4 commits into from
Sep 7, 2024
Merged

docs: use the right link for app.go #21585

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f75296
use the right link for app.go
GINMEL Sep 7, 2024
bcdad3e
Update link in 02
GINMEL Sep 7, 2024
56f71e5
fix
GINMEL Sep 7, 2024
d3c8a8c
fix 02-process-proposal.
GINMEL Sep 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/build/abci/01-prepare-proposal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ https://github.com/cosmos/cosmos-sdk/blob/v0.50.0-alpha.0/baseapp/abci_utils.go
```

This default implementation can be overridden by the application developer in
favor of a custom implementation in [`app.go`](https://docs.cosmos.network/main/build/building-apps/app-go-v2):
GINMEL marked this conversation as resolved.
Show resolved Hide resolved
favor of a custom implementation in [`app_di.go`](https://docs.cosmos.network/main/build/building-apps/app-go-di):

```go
prepareOpt := func(app *baseapp.BaseApp) {
Expand All @@ -42,4 +42,4 @@ prepareOpt := func(app *baseapp.BaseApp) {
}

baseAppOptions = append(baseAppOptions, prepareOpt)
```
```
2 changes: 1 addition & 1 deletion docs/build/abci/02-process-proposal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ https://github.com/cosmos/cosmos-sdk/blob/v0.50.0-alpha.0/baseapp/abci_utils.go#
```

Like `PrepareProposal` this implementation is the default and can be modified by
the application developer in [`app.go`](https://docs.cosmos.network/main/build/building-apps/app-go-v2). If you decide to implement
the application developer in [`app.go`](https://docs.cosmos.network/main/build/building-apps/app-go). If you decide to implement
GINMEL marked this conversation as resolved.
Show resolved Hide resolved
your own `ProcessProposal` handler, you must be sure to ensure that the transactions
provided in the proposal DO NOT exceed the maximum block gas and `maxtxbytes` (if set).

Expand Down
Loading