Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Circle issue with merging from forks #2115

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Fix Circle issue with merging from forks #2115

merged 1 commit into from
Aug 21, 2018

Conversation

jackzampolin
Copy link
Member

A recent change in circle is causing issues with people opening PRs from forks: https://discuss.circleci.com/t/saving-cache-stopped-working-warning-skipping-this-step-disabled-in-configuration/24423/2

This removes our use of caching

@codecov
Copy link

codecov bot commented Aug 21, 2018

Codecov Report

Merging #2115 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2115   +/-   ##
========================================
  Coverage    63.83%   63.83%           
========================================
  Files          113      113           
  Lines         6684     6684           
========================================
  Hits          4267     4267           
  Misses        2133     2133           
  Partials       284      284

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@jaekwon jaekwon merged commit 204762b into develop Aug 21, 2018
@jaekwon jaekwon deleted the jack/ci-fix branch August 21, 2018 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants