chore: remove crisis modules #20809
chore: remove crisis modules #20809
Conversation
|
Warning Rate limit exceeded@tac0turtle has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 46 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent changes span multiple components within the project, primarily involving the removal of references to the Changes
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (4)
api/cosmos/crisis/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.gox/crisis/proto/buf.lockis excluded by!**/*.lockx/crisis/types/genesis.pb.gois excluded by!**/*.pb.gox/crisis/types/tx.pb.gois excluded by!**/*.pb.go
Files selected for processing (6)
- buf.work.yaml (1 hunks)
- simapp/upgrades.go (2 hunks)
- simapp/v2/upgrades.go (2 hunks)
- testutil/configurator/configurator.go (3 hunks)
- x/README.md (1 hunks)
- x/upgrade/README.md (4 hunks)
Files skipped from review due to trivial changes (3)
- simapp/upgrades.go
- simapp/v2/upgrades.go
- x/README.md
Additional context used
Path-based instructions (2)
testutil/configurator/configurator.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/upgrade/README.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
LanguageTool
x/upgrade/README.md
[style] ~16-~16: Consider removing “of” to be more concise
Context: ...upgrading a live chain is risky because all of the validators need to pause their state ma...(ALL_OF_THE)
[style] ~17-~17: ‘exactly the same’ might be wordy. Consider a shorter alternative.
Context: ...s need to pause their state machines at exactly the same point in the process. If this is not do...(EN_WORDINESS_PREMIUM_EXACTLY_THE_SAME)
[style] ~18-~18: To elevate your writing, try using a synonym here.
Context: ... can be state inconsistencies which are hard to recover from. * [Concepts](#concept...(HARD_TO)
[uncategorized] ~65-~65: This expression is ususally spelled with a hyphen
Context: ...the chain. Naturally, thisHandleris application specific and not defined on a per-module basis. ...(SPECIFIC_HYPHEN)
[uncategorized] ~82-~82: This expression is ususally spelled with a hyphen
Context: ...n the chain. ThisStoreLoaderis also application specific and not defined on a per-module basis. ...(SPECIFIC_HYPHEN)
[uncategorized] ~94-~94: A comma may be missing after the conjunctive/linking adverb ‘Also’.
Context: ...` multiple times every time on restart. Also if there are multiple upgrades planned ...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[style] ~149-~149: ‘Any and all’ might be wordy. Consider a shorter alternative.
Context: ...de` does not emit any events by itself. Any and all proposal related events are emitted thr...(EN_WORDINESS_PREMIUM_ANY_AND_ALL)
[uncategorized] ~168-~168: Possible missing article found.
Context: ...ows users to query the block header for height at which a completed upgrade was applie...(AI_HYDRA_LEO_MISSING_THE)
[typographical] ~293-~293: Usually, there’s no comma before “if”.
Context: ...ets the currently scheduled upgrade plan, if one exists. ```bash regen query upgrad...(IF_NO_COMMA)
Markdownlint
x/upgrade/README.md
25-25: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
26-26: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
27-27: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
Additional comments not posted (3)
buf.work.yaml (1)
Line range hint
1-21: Configuration update approved.The removal of the
x/crisis/protodirectory frombuf.work.yamlaligns with the PR's objective to remove the crisis module. This change is consistent and does not appear to affect other modules.testutil/configurator/configurator.go (1)
Line range hint
1-255: Configuration update indefaultConfigfunction approved.The removal of the
crisismodule from the configuration lists in thedefaultConfigfunction aligns with the PR's objectives. The changes are consistent and maintain the integrity of the remaining module configurations.x/upgrade/README.md (1)
Line range hint
1-400: Documentation updates inx/upgrade/README.mdapproved.The removal of the crisis module version and adjustments to the module versions list are accurately reflected in the documentation. The reordering of the
CLI,REST, andgRPCsections underClientimproves readability and organization.Consider revising the list indentation.
The indentation for the list items underClientis inconsistent with Markdown best practices.- * [CLI](#cli) - * [REST](#rest) - * [gRPC](#grpc) + * [CLI](#cli) + * [REST](#rest) + * [gRPC](#grpc)Tools
Markdownlint
25-25: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
26-26: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
27-27: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- simapp/upgrades.go (2 hunks)
- simapp/v2/upgrades.go (2 hunks)
Files skipped from review as they are similar to previous changes (2)
- simapp/upgrades.go
- simapp/v2/upgrades.go
Description
This pr removes the crisis module in favour of directing users to use the circuit breaker. Secondly invariants will be used in testing and siulations going forward.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
Documentation
Crisismodule from project documentation.Refactor
Crisismodule from configuration and upgrade handlers.defaultConfigfunction by excluding theCrisismodule.Chores
x/crisis/protodirectory.