Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x/accounts): remove double execute #20065

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix(x/accounts): remove double execute #20065

merged 1 commit into from
Apr 17, 2024

Conversation

sontrinh16
Copy link
Member

@sontrinh16 sontrinh16 commented Apr 17, 2024 •
edited by coderabbitai bot
Loading

Description

Msg get invoked twice both in SendModuleMessageUntyped and sendModuleMessage

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Refactor
    • Updated the method for sending module messages to directly return responses and errors, enhancing reliability and error handling.

@sontrinh16 sontrinh16 requested a review from a team as a code owner April 17, 2024 04:37
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 17, 2024 •
edited
Loading

Walkthrough

Walkthrough

The update involves a modification in the message handling function within the keeper.go file of the x/accounts module. The function SendModuleMessageUntyped now returns resp and err directly, streamlining the process by eliminating an intermediary function call to k.sendModuleMessage. This change simplifies the message sending mechanism, potentially improving clarity and efficiency in module communication.

Changes

File Change Summary
x/accounts/.../keeper.go Updated the SendModuleMessageUntyped function to return resp and err directly, removing the call to k.sendModuleMessage.
Recent Review Details

Configuration used: .coderabbit.yml

Commits Files that changed from the base of the PR and between 2301e5e and 7022ebc.
Files selected for processing (1)
  • x/accounts/keeper.go (1 hunks)
Additional Context Used
Path-based Instructions (1)
x/accounts/keeper.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (1)
x/accounts/keeper.go (1)

332-332: The modification to directly return resp and err in SendModuleMessageUntyped effectively removes the redundant invocation of k.sendModuleMessage, aligning with the PR's objective to enhance efficiency.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
Contributor

@sontrinh16 your pull request is missing a changelog!

@julienrbrt julienrbrt changed the title remove double execute fix(x/accounts): remove double execute Apr 17, 2024
@sontrinh16 sontrinh16 mentioned this pull request Apr 17, 2024
Merged
12 tasks
@tac0turtle tac0turtle added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit eeefcf9 Apr 17, 2024
60 of 65 checks passed
@tac0turtle tac0turtle deleted the son/fix_double_execute branch April 17, 2024 08:04
alpe added a commit that referenced this pull request Apr 17, 2024
@alpe
Merge branch 'main' into alex/system_tests_wip
af4ee9c 
* main:
  build(deps): Bump github.com/pelletier/go-toml/v2 from 2.2.0 to 2.2.1 in /tools/confix (#20052)
  build(deps): Bump cosmossdk.io/api from 0.7.3 to 0.7.4 (#20063)
  fix: secp256r1 json missing quotes (#20060)
  fix(x/accounts): remove double execute (#20065)
  refactor(x/accounts): Skip Importing Unregistered Genesis Account Types (#20053)
  refactor(x/simulation)!: remove accounts string (#20056)
  fix(baseapp): don't share global gas meter in tx execution (#19616)
  feat(x/accounts): use router service from env (#20003)
  refactor(x): remove Address.String() (#20048)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@testinginprod testinginprod Awaiting requested review from testinginprod testinginprod is a code owner

Assignees
No one assigned
Labels
C:x/accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sontrinh16 @tac0turtle @julienrbrt