feat(baseapp): allow msg server to do type coercion in the most naive way #19837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows someone to call a msg handler with a go type that is different from the go type used in the msg handler. It's a naive, simple way to do something similar to hybrid handlers but assumes that all messages can be marshaled/unmarshaled using gogo
proto.Marshal/Unmarshal
.If cosmos/gogoproto#119 is merged, this will cover all of these cases:
Rather than checking if something is v1 or v2, looking in any registries or what not, we simply marshal/unmarshal if the go types aren't the same. If gogo proto supports both types, then this will work, otherwise you did something unsupported.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...