fix: prevent panic in RedeemTokensForShares when too few tokens are redeemed#19076
Merged
sainoe merged 7 commits intofeature/v0.47.x-ics-lsmfrom Jan 17, 2024
Merged
fix: prevent panic in RedeemTokensForShares when too few tokens are redeemed#19076sainoe merged 7 commits intofeature/v0.47.x-ics-lsmfrom
RedeemTokensForShares when too few tokens are redeemed#19076sainoe merged 7 commits intofeature/v0.47.x-ics-lsmfrom
Conversation
alexanderbez
approved these changes
Jan 16, 2024
sampocs
reviewed
Jan 17, 2024
x/staking/keeper/msg_server.go
Outdated
Comment on lines
+858
to
+859
| shareDenomSupply := k.bankKeeper.GetSupply(ctx, shareToken.Denom) | ||
| shares := delegation.Shares.Mul(sdk.NewDecFromInt(shareToken.Amount)).QuoInt(shareDenomSupply.Amount) |
Contributor
There was a problem hiding this comment.
Apologies for the confusion, but can you elaborate on why this is inaccurate in the case of a validator having pending rewards or being slashed?
The LSM token is intended to map 1:1 with shares (it is minted based on shares, not tokens), so I was under the assumption that it would naturally capture rewards/slashing.
Contributor
Author
There was a problem hiding this comment.
The LSM token is intended to map 1:1 with shares (it is minted based on shares, not tokens), so I was under the assumption that it would naturally capture rewards/slashing.
You're 100% right. Sorry, I got it the wrong way. The simulation tests were failing due to these lines, which don't use a 1:1 mapping between LSM tokens and shares.
JayT106
pushed a commit
to JayT106/cosmos-sdk
that referenced
this pull request
Feb 15, 2024
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
InRedeemTokensForShares(), this line establishes a 1:1 mapping between the redeemed token amount and shares.However, this mapping is accurate only when a validator hasn't received any rewards and hasn't been slashed.
This PR changes the mapping by calculating shares as a fraction of the redeemed tokensand the total share token supply, akin to the approach taken here.
Edit: This PR updates RedeemTokensForShares to return an error when the redemption amount is too small and truncates to 0 shares. That prevents a panic in SendCoins.
cc @sampocs
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...