chore(staking): update 0.47-lsm with staking changes#18313
Closed
zmanian wants to merge 3 commits intocosmos:release/v0.47.xfrom
Closed
chore(staking): update 0.47-lsm with staking changes#18313zmanian wants to merge 3 commits intocosmos:release/v0.47.xfrom
zmanian wants to merge 3 commits intocosmos:release/v0.47.xfrom
Conversation
Contributor
|
Important Auto Review SkippedDraft detected. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the TipsChat with CodeRabbit Bot (
|
github-actions
bot
added
C:x/staking
C:CLI
C:x/distribution
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Msg_UpdateParams_FullMethodName = "/cosmos.distribution.v1beta1.Msg/UpdateParams" | ||
| Msg_CommunityPoolSpend_FullMethodName = "/cosmos.distribution.v1beta1.Msg/CommunityPoolSpend" | ||
| Msg_WithdrawTokenizeShareRecordReward_FullMethodName = "/cosmos.distribution.v1beta1.Msg/WithdrawTokenizeShareRecordReward" | ||
| Msg_WithdrawAllTokenizeShareRecordReward_FullMethodName = "/cosmos.distribution.v1beta1.Msg/WithdrawAllTokenizeShareRecordReward" |
Check failure
Code scanning / gosec
Potential hardcoded credentials
| Msg_FundCommunityPool_FullMethodName = "/cosmos.distribution.v1beta1.Msg/FundCommunityPool" | ||
| Msg_UpdateParams_FullMethodName = "/cosmos.distribution.v1beta1.Msg/UpdateParams" | ||
| Msg_CommunityPoolSpend_FullMethodName = "/cosmos.distribution.v1beta1.Msg/CommunityPoolSpend" | ||
| Msg_WithdrawTokenizeShareRecordReward_FullMethodName = "/cosmos.distribution.v1beta1.Msg/WithdrawTokenizeShareRecordReward" |
Check failure
Code scanning / gosec
Potential hardcoded credentials
| Query_DelegatorValidators_FullMethodName = "/cosmos.distribution.v1beta1.Query/DelegatorValidators" | ||
| Query_DelegatorWithdrawAddress_FullMethodName = "/cosmos.distribution.v1beta1.Query/DelegatorWithdrawAddress" | ||
| Query_CommunityPool_FullMethodName = "/cosmos.distribution.v1beta1.Query/CommunityPool" | ||
| Query_TokenizeShareRecordReward_FullMethodName = "/cosmos.distribution.v1beta1.Query/TokenizeShareRecordReward" |
Check failure
Code scanning / gosec
Potential hardcoded credentials
| func (msg MsgWithdrawTokenizeShareRecordReward) GetSigners() []sdk.AccAddress { | ||
| owner, err := sdk.AccAddressFromBech32(msg.OwnerAddress) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
| func (msg MsgWithdrawAllTokenizeShareRecordReward) GetSigners() []sdk.AccAddress { | ||
| owner, err := sdk.AccAddressFromBech32(msg.OwnerAddress) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
tac0turtle
changed the title
This was referenced Nov 27, 2023
Closed
20 tasks
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for #18200
Extremely work in progress and targeted to the wrong branch right now.