feat(client): allow overwritting client.toml #17513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
julienrbrt
commented
Aug 24, 2023
simapp/simd/cmd/commands.go
Outdated
| @@ -95,10 +135,10 @@ func initAppConfig() (string, interface{}) { | |||
| customAppTemplate := serverconfig.DefaultConfigTemplate + ` | |||
| [wasm] | |||
| # This is the maximum sdk gas (wasm and storage) that we allow for any x/wasm "smart" queries | |||
| query_gas_limit = 300000 | |||
| query-gas-limit = {{ .WASM.QueryGasLimit }} | |||
There was a problem hiding this comment.
This needs to be backported to all previous versions to give a proper example.
julienrbrt
commented
Aug 24, 2023
client/config/config.go
Outdated
| } | ||
|
|
||
| // ReadFromClientConfig reads values from client.toml file and updates them in client Context | ||
| func ReadFromClientConfig(ctx client.Context) (client.Context, error) { | ||
| // CreateClientConfigAndContext reads the client.toml file and returns a new populated client.Context |
There was a problem hiding this comment.
The name is long but defines better what the function does than how ReadFromClientConfig was named.
julienrbrt
requested review from
alexanderbez and
ValarDragon
and removed request for
samricotta and
atheeshp
20 tasks
|
EDIT: won't do until requested. |
|
@Mergifyio backport release/v0.50.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
(cherry picked from commit 6601713) # Conflicts: # CHANGELOG.md # client/config/config.go # client/config/config_test.go # client/tx/factory.go # simapp/simd/cmd/commands.go # simapp/simd/cmd/root.go # simapp/simd/cmd/root_v2.go # simapp/simd/cmd/testnet.go
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #17253
I will make this PR non-breaking and backport this in v0.50.1.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change